-
Notifications
You must be signed in to change notification settings - Fork 24
fix: use-default-on-jsonpath-import #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
khvn26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I strongly suggest adding a test run in ESM mode to CI, if possible.
|
@khvn26 https://github.com/Flagsmith/flagsmith-nodejs-client/actions/runs/19830086799/job/56813609828?pr=231 New step Tests relying on mocks have been skipped due to incompatibilities with The previous tests are still running so this step is mostly to catch similar issues (that would have been caught) |
khvn26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid to me — will appreciate having an issue, or multiple issues, to fix the newly found problematic tests later.
import * as jsonpathcouldn't access submethods likejsonpath.queryDetails of the difference between the two systems: