Preventing errors while using this SDK #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was injecting a global variable ("config") and was only use to define a default value for the API URL.
We are rejecting with the detail message
Contributor
|
Hey thanks for the PR we will take a look right away 👍 |
Contributor
|
Thanks so much for the PR! |
Contributor
|
This is now in npm as version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using Flagsmith and so far we're pretty happy with it ;)
Since we're mostly a "JS shop", we're extensively using Node.JS to write our backend services and thus using this SDK to toggle features and set config values.
However we've noted some quirks related to API errors: the SDK wasn't correctly treating them and this resulted in errors since
handlingResponseassumes that theresvalue is of the expected value (i.e. a plain object).To reproduce this error, you simply have to use an incorrect "environment ID" value.