Skip to content

feat(Engine): Evaluate from EvaluationContext #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: feat/context-values-umbrella
Choose a base branch
from
+769 −55
Open

feat(Engine): Evaluate from EvaluationContext #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0eda242
Introduce context values evaluation data model
emyller Sep 16, 2025
3caac93
Update engine test data
emyller Sep 18, 2025
c3bc44a
Get ready for engine tests
emyller Sep 18, 2025
b285f7d
Introduce new engine
emyller Sep 19, 2025
7295ca8
Lint ✨
emyller Sep 24, 2025
fe68922
Make priority clearer
emyller Sep 26, 2025
7cf046c
Update EvaluationResult spec
emyller Oct 1, 2025
e2817c5
yay
emyller Oct 1, 2025
cc6ae4c
Fix identity traits data type
emyller Oct 2, 2025
8c57eb2
Update engine test data branch
emyller Oct 3, 2025
20ec0f1
Fix identity as an optional context
emyller Oct 4, 2025
8d0419e
Improve API
emyller Oct 4, 2025
d719f09
Make code reusable
emyller Oct 8, 2025
afa9011
Apples will never be bananas
emyller Oct 8, 2025
754d83a
Track TODO with an issue
emyller Oct 10, 2025
274ba16
Improve type handling in the IN operator
emyller Oct 10, 2025
15af377
Make MODULO check less prone to error
emyller Oct 10, 2025
3c0ad5b
Fix obtaining a context value
emyller Oct 10, 2025
e8619b0
Update comment to latest reality
emyller Oct 10, 2025
f7b070c
Delete skippable code
emyller Oct 10, 2025
0a201c6
Update test cases
emyller Oct 11, 2025
49d6cee
Fix tests
emyller Oct 11, 2025
d9d977c
Carry segment metadata around
emyller Oct 11, 2025
bfd03c3
Please run tests
emyller Oct 9, 2025
7d0d026
Comply with latest test data
emyller Oct 14, 2025
acc06b3
Ensure variants are selected consistently
emyller Oct 14, 2025
ef9b242
Update tests
emyller Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/pull-requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ name: Flagsmith PHP Pull Request

on:
pull_request:
branches:
- main
- release**

jobs:
test:
Expand Down
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[submodule "tests/Engine/EngineTests/EngineTestData"]
path = tests/Engine/EngineTests/EngineTestData
url = git@github.com:Flagsmith/engine-test-data.git
branch = v1.0.0
tag = v2.4.0
6 changes: 4 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,17 @@
"psr/simple-cache": ">=1.0",
"psr/http-factory-implementation": "1.0",
"psr/http-client-implementation": "1.0",
"psr/http-message-implementation": "1.0"
"psr/http-message-implementation": "1.0",
"softcreatr/jsonpath": "^0.10.0"
},
"require-dev": {
"guzzlehttp/guzzle": "^7.3",
"guzzlehttp/psr7": "^2.1.0",
"phpunit/phpunit": "^9.5",
"symfony/cache": "^5.4.6",
"friendsofphp/php-cs-fixer": "^3.6",
"doppiogancio/mocked-client": "^3.0"
"doppiogancio/mocked-client": "^3.0",
"colinodell/json5": "^3.0"
},
"autoload": {
"psr-4": {
Expand Down
Loading