Skip to content

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 16, 2025

In this PR, we pass the Flagsmith feature id as part of engine feature metadata.

Review difficulty: 2/5

@khvn26 khvn26 requested a review from a team as a code owner October 16, 2025 15:23
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team October 16, 2025 15:23
@khvn26 khvn26 changed the title feat: Support feature metadata @khvn26 feat: Support feature metadata Oct 16, 2025
@khvn26 khvn26 force-pushed the feat/support-feature-metadata branch from 65768e3 to e4616f0 Compare October 16, 2025 15:25
@khvn26 khvn26 force-pushed the feat/support-feature-metadata branch from e4616f0 to fdc89d6 Compare October 16, 2025 17:49
Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Couple questions.

@emyller emyller dismissed their stale review October 16, 2025 19:35

Not blocking.

@khvn26 khvn26 requested a review from emyller October 16, 2025 20:01
@matthewelwell
Copy link
Contributor

Approved based on Evandro's review, and having reviewed the remaining commits added since.

@khvn26 khvn26 merged commit 1bbbdf8 into main Oct 22, 2025
7 checks passed
@khvn26 khvn26 deleted the feat/support-feature-metadata branch October 22, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants