improvement/general-housekeeping #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformat
dabeeeenster
changed the title
Added prettir Fixed up some files
dabeeeenster
changed the title
matthewelwell
requested changes
May 18, 2023
.prettierignore
Outdated
| @@ -0,0 +1,6 @@ | |||
| # Ignore a bunch of files: | |||
Contributor
There was a problem hiding this comment.
This comment doesn't add any additional information that can't be inferred from the name of the file. Either improve the comment to explain why we're ignoring, or just remove. I don't mind which.
Contributor
Author
There was a problem hiding this comment.
OK yep - removed the ignore file and linted some html and json
.github/workflows/pytest.yml
Outdated
| strategy: | ||
| max-parallel: 4 | ||
| matrix: | ||
| python-version: ['3.7', '3.8', '3.9', '3.10'] |
Contributor
There was a problem hiding this comment.
We should drop 3.7 from here and add 3.11 but I think @kim has done this in another PR already?
Contributor
Author
There was a problem hiding this comment.
Couldnt find that PR so updated this file
matthewelwell
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.