Skip to content

feat: Bump flagsmith-flag-engine to 5.0.0 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat: Bump flagsmith-flag-engine to 5.0.0 #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions flagsmith/flagsmith.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import requests
from flag_engine import engine
from flag_engine.environments.builders import build_environment_model
from flag_engine.environments.models import EnvironmentModel
from flag_engine.identities.models import IdentityModel, TraitModel
from flag_engine.segments.evaluator import get_identity_segments
Expand Down Expand Up @@ -196,7 +195,7 @@ def update_environment(self):

def _get_environment_from_api(self) -> EnvironmentModel:
environment_data = self._get_json_response(self.environment_url, method="GET")
return build_environment_model(environment_data)
return EnvironmentModel.model_validate(environment_data)

def _get_environment_flags_from_document(self) -> Flags:
return Flags.from_feature_state_models(
Expand Down
6 changes: 2 additions & 4 deletions flagsmith/offline_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import json
from abc import ABC, abstractmethod

from flag_engine.environments.builders import build_environment_model
from flag_engine.environments.models import EnvironmentModel


Expand All @@ -14,8 +12,8 @@ def get_environment(self) -> EnvironmentModel:
class LocalFileHandler(BaseOfflineHandler):
def __init__(self, environment_document_path: str):
with open(environment_document_path) as environment_document:
self.environment = build_environment_model(
json.loads(environment_document.read())
self.environment = EnvironmentModel.model_validate_json(
environment_document.read()
)

def get_environment(self) -> EnvironmentModel:
Expand Down
Loading