Feat/client site rewrite #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
requested review from
matthewelwell
and removed request for
matthewelwell
matthewelwell
approved these changes
May 31, 2022
gagantrivedi
force-pushed
the
feat/client-site-rewrite
branch
from
1906479 to
cbbf8ce
Compare
gagantrivedi
added a commit
that referenced
this pull request
Jun 7, 2022
* update lib.rs * fix(models/Flag): use flagsmith value type * fixup! wip: get_identity_flags: Add signature * rewrite error module * fix(analytics): make new public * expand public interface and add default handler and analytics * fix references * Add analytics to models * update author * misc: improve interface remove redundant code * use flag engine from github * make traits optional for get_identity_flags * Add default trait to Flag * update example with default handler * exit threads on flagsmith client being dropped * fix warnings * update example: add readme * minor refactoring * Add tests for Flag * fix(*._identity_flags): use &str for identifier * feat(flag/model): Add a method to get value as string * tests(analytics_processor): Add tests and minor tweaks * tests: Add fixtures * feat(flag): Add value_as_type getters * test(polling): Add tests for polling thread and minor fixes * fix(default_handler): Add tests * test(error/mod): Add tests for errors * expose segments * Add flag engine * update flag engine crate in example cargo.toml * fix typo * bump flag-engine * Update default url to edge * fixup! bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.