feat(CockroachDB support): Switch to JSONField for SDK metrics labels#5833
feat(CockroachDB support): Switch to JSONField for SDK metrics labels#5833
JSONField for SDK metrics labels#5833Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5833 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 1335 1337 +2
Lines 49876 49910 +34
=======================================
+ Hits 49039 49073 +34
Misses 837 837 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Confirming this fix allows CockroachDB to work without needing to update Psycopg to 3.1+. |
Zaimwa9
left a comment
There was a problem hiding this comment.
The migrations look redundant except if I am missing something? Can we see to merge them together maybe ?
|
@Zaimwa9 Indeed these migrations look very similar, but their purpose is actually different:
So, to answer your question, no, we can't merge these migrations as they cater for different scenarios, and I argue they are not in fact redundant. |
Zaimwa9
left a comment
There was a problem hiding this comment.
Alright thanks for the details, I felt that under the hood there was a migration purpose
|
I forgot to add as notes to my last review: not actually requesting any changes unless proven necessary by the comment I added. |
|
any updates? |
|
@krahllucas Hello, sorry for the radio silence here — we've just prioritised this and are planning to release it until the end of Q1. |
- Add missing DECLARE for PL/pgSQL loop variable - Drop column default before type change to avoid cast error - Renumber migration to 0008 after rebase (0007 conflict) - Add tests for both fresh install and hstore upgrade paths
6c848c6 to
7f0f7a3
Compare
JSONField for SDK metrics labelsJSONField for SDK metrics labels
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
This migrates all the
labelsfields added in #5623 tojsonbas thehstoresupport turned out to be problematic:hstoreextension requires enabling additional parameter sets in some cloud environments (e.g. Azure).Note that due to problem 1, I've removed the
CREATE EXTENSIONoperation from the original migration.How did you test this code?
Migrations and tests run ok.
Will be smoke-tested against CockroachDB as well.