fix: move AWS_SSE_LOGS_BUCKET_NAME to task-processor definition#6284
Merged
gagantrivedi merged 1 commit intomainfrom Nov 13, 2025
Merged
fix: move AWS_SSE_LOGS_BUCKET_NAME to task-processor definition#6284gagantrivedi merged 1 commit intomainfrom
gagantrivedi merged 1 commit intomainfrom
Conversation
PR #6232 re-enabled SSE usage tracking by adding the AWS_SSE_LOGS_BUCKET_NAME environment variable, but it was incorrectly added to the web task definition (ecs-task-definition-web.json) instead of the task processor definition (ecs-task-definition-task-processor.json). This commit fixes that by: - Adding AWS_SSE_LOGS_BUCKET_NAME to ecs-task-definition-task-processor.json - Removing AWS_SSE_LOGS_BUCKET_NAME from ecs-task-definition-web.json The SSE usage tracking logic runs in the task processor, not the web service, so the environment variable needs to be configured in the correct task definition.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
gagantrivedi
requested review from
a team and
emyller
and removed request for
a team and
khvn26
matthewelwell
approved these changes
Nov 13, 2025
gagantrivedi
added a commit
that referenced
this pull request
Nov 13, 2025
Removing AWS_SSE_LOGS_BUCKET_NAME from the task processor for now. The data processing doesn't seem fast enough yet, so we need to investigate and optimize before enabling this again. This temporarily reverts the change from PR #6284.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
PR #6232 re-enabled SSE usage tracking by adding the AWS_SSE_LOGS_BUCKET_NAME environment variable, but it was incorrectly added to the web task definition (ecs-task-definition-web.json) instead of the task processor definition (ecs-task-definition-task-processor.json).
This commit fixes that by:
The SSE usage tracking logic runs in the task processor, not the api service, so the environment variable needs to be configured in the correct task definition.
How did you test this code?
n/a