Conversation
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
…ent-feature-state-view # Conflicts: # frontend/web/components/modals/AssociatedSegmentOverrides.js
…ent-feature-state-view
# Conflicts: # frontend/web/components/feature-summary/FeatureTags.tsx # frontend/web/components/pages/UserPage.tsx
…ent-feature-state-view # Conflicts: # frontend/common/stores/feature-list-store.ts # frontend/web/components/modals/AssociatedSegmentOverrides.js # frontend/web/components/segments/Rule/components/RuleConditionValueInput.tsx
|
Good spot RE those @talissoncosta. I think we need to sort this out project-wide, more things are starting to use environment.id vs api_key. We should start a convention that explicitly states environmentAPIKey rather than environmentId in the cases we're using the api_key string. I'll take a look at tackling this in a followup PR separate to this. |
# Conflicts: # frontend/web/components/modals/create-feature/index.js
Replace manual _data.get() calls and useCallback paging logic with useGetIdentityOverridesQuery and useCreateIdentityOverrideMutation. Permission check for edge identities now uses useHasPermission hook. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Vertically align Edit and delete buttons - Move enabled switch to right of remote config value - Add margin to identifier and Edit button - Trigger FeatureListStore saved event on create/delete to refresh FeaturesPage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Looks good — all feedback addressed. The environment ID bugs in IdentityOverridesTab and SegmentOverridesTab are fixed.
Thanks so much for the hard work on it @kyle-ssg
Totally agree! Thanks for that @kyle-ssg |
2 participants
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Migrates all tabs including the create feature modal itself to TypeScript, no type errors to do with creating / editing a feature and also reduces the feature modal by ~1200 LoC.
Migrates a few components to ES export
How did you test this code?