Skip to content

fix: Skip logout endpoint in e2e#7089

Merged
kyle-ssg merged 1 commit intomainfrom
fix/e2e-logout
Apr 1, 2026
Merged

fix: Skip logout endpoint in e2e#7089
kyle-ssg merged 1 commit intomainfrom
fix/e2e-logout

Conversation

@kyle-ssg
Copy link
Copy Markdown
Member

@kyle-ssg kyle-ssg commented Apr 1, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

#7067 introduced calling the logout endpoint when a user clicks logout. The problem with this is that when a user logs in it reuses an existing token if one exists, meaning that logging out in 1 test invalidated existing sessions.

How did you test this code?

E2E

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 1, 2026 9:56am
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 1, 2026 9:56am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 1, 2026 9:56am

Request Review

@kyle-ssg kyle-ssg requested a review from a team as a code owner April 1, 2026 09:56
@kyle-ssg kyle-ssg requested review from Zaimwa9 and removed request for a team April 1, 2026 09:56
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7089 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7089 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7089 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7089 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7089 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7089 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  23.5 seconds
commit  1fa1d00
info  🔄 Run: #15604 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  49.8 seconds
commit  1fa1d00
info  🔄 Run: #15604 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  43.1 seconds
commit  1fa1d00
info  🔄 Run: #15604 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  57.8 seconds
commit  1fa1d00
info  🔄 Run: #15604 (attempt 1)

@kyle-ssg kyle-ssg merged commit 9a6aa07 into main Apr 1, 2026
27 checks passed
@kyle-ssg kyle-ssg deleted the fix/e2e-logout branch April 1, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants