fix(Dogfooding): OpenFeature-gated flags always resolving to default#7310
fix(Dogfooding): OpenFeature-gated flags always resolving to default#7310
Conversation
The `flagsmith-api` domain falls back to a ready `NoOpProvider` until `set_provider` is called, so `get_provider_status() != READY` never triggered `initialise_provider`. Every OpenFeature-gated flag silently resolved to its default — including `compress_dynamo_documents`, which hasn't compressed any environment documents since PR #7008 shipped. beep boop
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7310 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 1377 1377
Lines 51610 51636 +26
=======================================
+ Hits 50786 50812 +26
Misses 824 824 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Visual Regression16 screenshots compared. See report for details. |
2 participants
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7008.
The
flagsmith-apidomain falls back to a readyNoOpProvideruntilset_provideris called, so thestatus != READYguard inget_openfeature_clientnever runsinitialise_provider. Every OpenFeature-gated flag silently resolves to its default —compress_dynamo_documentshasn't compressed a document since #7008 shipped.Check
get_provider_metadata(domain).is_default_providerinstead.How did you test this code?
New unit tests in
tests/unit/integrations/flagsmith/test_unit_flagsmith_client.pyexercise the realopenfeature_apiregistry, which the existing coverage fully mocked (why this slipped through).