fix(GitLab): GitLab webhooks not reaching our API#7357
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7357 +/- ##
==========================================
- Coverage 98.43% 98.43% -0.01%
==========================================
Files 1395 1395
Lines 52514 52513 -1
==========================================
- Hits 51691 51690 -1
Misses 823 823 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Visual Regression16 screenshots compared. See report for details. |
khvn26
left a comment
There was a problem hiding this comment.
The OAuth approach almost looks more correct to me:
flagsmith/api/oauth2_metadata/dataclasses.py
Lines 21 to 22 in e44ea99
However, the implication of having to properly document the setting, and update it for every single installation, is unpleasant.
Approving as a compromise before we figure our a common approach to this — that could include patching webhooks through FE, or figuring out django sites configuration for split FE/API installations.
I have added information todocs/if required so people know about the feature.Changes
Closes #7355
Fix our API URL in GitLab webhooks so they actually point to the API.
How did you test this code?
I will once in production.