Skip to content

fix(GitLab): GitLab webhooks not reaching our API#7357

Merged
emyller merged 2 commits intomainfrom
fix/gitlab-webhook-url
Apr 28, 2026
Merged

fix(GitLab): GitLab webhooks not reaching our API#7357
emyller merged 2 commits intomainfrom
fix/gitlab-webhook-url

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented Apr 28, 2026

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #7355

Fix our API URL in GitLab webhooks so they actually point to the API.

How did you test this code?

I will once in production.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@emyller emyller self-assigned this Apr 28, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 28, 2026 3:23pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ignored Ignored Preview Apr 28, 2026 3:23pm
flagsmith-frontend-staging Ignored Ignored Preview Apr 28, 2026 3:23pm

Request Review

@github-actions github-actions Bot added api Issue related to the REST API fix labels Apr 28, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added docs Documentation updates fix and removed fix docs Documentation updates labels Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.43%. Comparing base (e44ea99) to head (6177917).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7357      +/-   ##
==========================================
- Coverage   98.43%   98.43%   -0.01%     
==========================================
  Files        1395     1395              
  Lines       52514    52513       -1     
==========================================
- Hits        51691    51690       -1     
  Misses        823      823              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller emyller marked this pull request as ready for review April 28, 2026 15:30
@emyller emyller requested review from a team as code owners April 28, 2026 15:30
@emyller emyller requested review from gagantrivedi and removed request for a team April 28, 2026 15:30
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@github-actions github-actions Bot added fix and removed fix labels Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7357 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7357 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7357 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7357 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7357 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7357 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  39.8 seconds
commit  6177917
info  🔄 Run: #16388 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  1 second
commit  6177917
info  🔄 Run: #16388 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  59.1 seconds
commit  6177917
info  🔄 Run: #16388 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 1 second
commit  6177917
info  🔄 Run: #16388 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

16 screenshots compared. See report for details.
View full report

Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OAuth approach almost looks more correct to me:

api_url=settings.FLAGSMITH_API_URL.rstrip("/"),
frontend_url=settings.FLAGSMITH_FRONTEND_URL.rstrip("/"),

However, the implication of having to properly document the setting, and update it for every single installation, is unpleasant.

Approving as a compromise before we figure our a common approach to this — that could include patching webhooks through FE, or figuring out django sites configuration for split FE/API installations.

@emyller emyller merged commit 4d772cc into main Apr 28, 2026
54 of 55 checks passed
@emyller emyller deleted the fix/gitlab-webhook-url branch April 28, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitLab webhooks pointing to frontend website instead of API

2 participants