Skip to content

fix: added currency and frequency in ids resolution#7442

Merged
Zaimwa9 merged 6 commits intomainfrom
fix/map-scaleup-plan-with-frequency-currency-ids
May 7, 2026
Merged

fix: added currency and frequency in ids resolution#7442
Zaimwa9 merged 6 commits intomainfrom
fix/map-scaleup-plan-with-frequency-currency-ids

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented May 6, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • IDs in real environment use the frequency and the currency in chargebee

How did you test this code?

  • Added tests
    Tested on staging entirely with all the combinations
image

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 6, 2026 13:29
@Zaimwa9 Zaimwa9 requested review from khvn26 and removed request for a team May 6, 2026 13:29
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 7, 2026 2:43pm
flagsmith-frontend-preview Ignored Ignored Preview May 7, 2026 2:43pm
flagsmith-frontend-staging Ignored Ignored Preview May 7, 2026 2:43pm

Request Review

khvn26
khvn26 previously approved these changes May 6, 2026
@github-actions github-actions Bot added api Issue related to the REST API fix labels May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7442 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7442 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7442 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7442 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7442 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7442 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  43.6 seconds
commit  7fd5c82
info  🔄 Run: #16555 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  27.9 seconds
commit  7fd5c82
info  🔄 Run: #16555 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 17 seconds
commit  7fd5c82
info  🔄 Run: #16555 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  48.4 seconds
commit  7fd5c82
info  🔄 Run: #16555 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  24.2 seconds
commit  2c70231
info  🔄 Run: #16556 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  31.1 seconds
commit  2c70231
info  🔄 Run: #16556 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  42.7 seconds
commit  2c70231
info  🔄 Run: #16556 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  55.8 seconds
commit  2c70231
info  🔄 Run: #16556 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  6.3 seconds
commit  09cb8a2
info  🔄 Run: #16596 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  39.6 seconds
commit  f7a38d2
info  🔄 Run: #16595 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  52.6 seconds
commit  f7a38d2
info  🔄 Run: #16595 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  4.5 seconds
commit  09cb8a2
info  🔄 Run: #16596 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 8 seconds
commit  f7a38d2
info  🔄 Run: #16595 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  42.6 seconds
commit  f7a38d2
info  🔄 Run: #16595 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  24 seconds
commit  aa9e484
info  🔄 Run: #16600 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  47.4 seconds
commit  aa9e484
info  🔄 Run: #16600 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 18 seconds
commit  aa9e484
info  🔄 Run: #16600 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 2 seconds
commit  aa9e484
info  🔄 Run: #16600 (attempt 1)

khvn26
khvn26 previously approved these changes May 6, 2026
@github-actions github-actions Bot added fix and removed fix labels May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Visual Regression

16 screenshots compared. See report for details.
View full report

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.44%. Comparing base (b870482) to head (aa9e484).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7442   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files        1398     1398           
  Lines       52646    52654    +8     
=======================================
+ Hits        51826    51834    +8     
  Misses        820      820           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added fix and removed fix labels May 7, 2026
Zaimwa9 added 2 commits May 7, 2026 16:43
…thub.com:Flagsmith/flagsmith into fix/map-scaleup-plan-with-frequency-currency-ids
@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 7, 2026 14:43
@github-actions github-actions Bot added docs Documentation updates fix and removed fix docs Documentation updates labels May 7, 2026
@matthewelwell
Copy link
Copy Markdown
Contributor

@claude review

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, comment @claude review on this pull request to trigger a review.

@matthewelwell
Copy link
Copy Markdown
Contributor

@claude review

@Zaimwa9 Zaimwa9 requested a review from khvn26 May 7, 2026 15:23
@Zaimwa9 Zaimwa9 merged commit e4651d1 into main May 7, 2026
37 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/map-scaleup-plan-with-frequency-currency-ids branch May 7, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants