Skip to content

fix: removed api logout call#7448

Merged
Zaimwa9 merged 1 commit intomainfrom
fix/remove-logout-api-call
May 7, 2026
Merged

fix: removed api logout call#7448
Zaimwa9 merged 1 commit intomainfrom
fix/remove-logout-api-call

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented May 7, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

As logging out from the API invalidate the user token, we reverted to not calling the API when logging out from dashboard

How did you test this code?

@Zaimwa9 Zaimwa9 requested a review from matthewelwell May 7, 2026 07:34
@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 7, 2026 07:34
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team May 7, 2026 07:34
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment May 7, 2026 7:35am
flagsmith-frontend-staging Ready Ready Preview, Comment May 7, 2026 7:35am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored May 7, 2026 7:35am

Request Review

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label May 7, 2026
@github-actions github-actions Bot added the fix label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7448 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7448 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7448 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7448 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7448 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7448 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  42.9 seconds
commit  1655d81
info  🔄 Run: #16585 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  46.8 seconds
commit  1655d81
info  🔄 Run: #16585 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 4 seconds
commit  1655d81
info  🔄 Run: #16585 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  47.8 seconds
commit  1655d81
info  🔄 Run: #16585 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Visual Regression

16 screenshots compared. See report for details.
View full report

Copy link
Copy Markdown
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For additional context, this is being done because the token is presented to users in their account settings as an 'API key'. Until we build properly scoped user API keys, or just force everyone to use org-level API keys, we cannot invalidate these tokens on logout.

@Zaimwa9 Zaimwa9 merged commit bff665f into main May 7, 2026
30 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/remove-logout-api-call branch May 7, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants