fix: pass django-settings-modules as make argument to override env local#7552
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7552 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 1400 1400
Lines 53034 53034
=======================================
Hits 52224 52224
Misses 810 810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Makefile's
.EXPORT_ALL_VARIABLES+-include .env-localcausesDJANGO_SETTINGS_MODULE=app.settings.localto override the step-level env var, loadingdebug_toolbarwhich isn't installed in CI.Fix:
DJANGO_SETTINGS_MODULEas a Make argument instead, which has the highest precedence and can't be overridden by included env files.How did you test this code?