Skip to content

fix: pass django-settings-modules as make argument to override env local#7552

Merged
Zaimwa9 merged 1 commit into
mainfrom
fix/mcp-schema-generation-settings
May 20, 2026
Merged

fix: pass django-settings-modules as make argument to override env local#7552
Zaimwa9 merged 1 commit into
mainfrom
fix/mcp-schema-generation-settings

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented May 20, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Makefile's .EXPORT_ALL_VARIABLES + -include .env-local causes DJANGO_SETTINGS_MODULE=app.settings.local to override the step-level env var, loading debug_toolbar which isn't installed in CI.

Fix:

  • Pass DJANGO_SETTINGS_MODULE as a Make argument instead, which has the highest precedence and can't be overridden by included env files.

How did you test this code?

  • Locally, resetting the modules until resolution

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 20, 2026 10:06
@Zaimwa9 Zaimwa9 requested review from germangarces and removed request for a team May 20, 2026 10:06
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored May 20, 2026 10:06am
flagsmith-frontend-preview Ignored Ignored May 20, 2026 10:06am
flagsmith-frontend-staging Ignored Ignored May 20, 2026 10:06am

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7552 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7552 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7552 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7552 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7552 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7552 Finished ✅ Results

@github-actions github-actions Bot added the fix label May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.47%. Comparing base (7037006) to head (bbf968b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7552   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files        1400     1400           
  Lines       53034    53034           
=======================================
  Hits        52224    52224           
  Misses        810      810           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.2 seconds
commit  bbf968b
info  🔄 Run: #16858 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  42.8 seconds
commit  bbf968b
info  🔄 Run: #16858 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  39.5 seconds
commit  bbf968b
info  🔄 Run: #16858 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  48.6 seconds
commit  bbf968b
info  🔄 Run: #16858 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@Zaimwa9 Zaimwa9 merged commit 072a0b0 into main May 20, 2026
34 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/mcp-schema-generation-settings branch May 20, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants