Skip to content

feat(experimentation): Snowflake warehouse connection support#7565

Merged
Zaimwa9 merged 1 commit into
mainfrom
feat/experimentation-external-snowflake-warehouse-api-clean
May 22, 2026
Merged

feat(experimentation): Snowflake warehouse connection support#7565
Zaimwa9 merged 1 commit into
mainfrom
feat/experimentation-external-snowflake-warehouse-api-clean

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented May 21, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Add config JSONField (nullable) and created status to WarehouseConnection model, enabling type-specific configuration storage
  • Add SnowflakeConfig TypedDict in experimentation/types.py with defaults for all fields except account_identifier (required)
  • Extend serializer with per-type config validation (Snowflake defaults merging, Flagsmith rejects config), writable name, and partial update support
  • Add UpdateModelMixin to the ViewSet for PATCH support with audit logging

How did you test this code?

  • 35 tests covering Snowflake creation, defaults, validation, resurrection, PATCH updates, and permissions

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 21, 2026 15:11
@Zaimwa9 Zaimwa9 requested review from emyller and removed request for a team May 21, 2026 15:11
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored May 21, 2026 3:11pm
flagsmith-frontend-preview Ignored Ignored May 21, 2026 3:11pm
flagsmith-frontend-staging Ignored Ignored May 21, 2026 3:11pm

Request Review

@github-actions github-actions Bot added api Issue related to the REST API feature New feature or request labels May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7565 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7565 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7565 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7565 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7565 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7565 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.1 seconds
commit  9cb6356
info  🔄 Run: #16894 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.7 seconds
commit  9cb6356
info  🔄 Run: #16894 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  42 seconds
commit  9cb6356
info  🔄 Run: #16894 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  57 seconds
commit  9cb6356
info  🔄 Run: #16894 (attempt 1)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.49%. Comparing base (b10a2c3) to head (9cb6356).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7565    +/-   ##
========================================
  Coverage   98.48%   98.49%            
========================================
  Files        1415     1417     +2     
  Lines       53595    53749   +154     
========================================
+ Hits        52785    52939   +154     
  Misses        810      810            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@Zaimwa9 Zaimwa9 requested review from gagantrivedi and removed request for emyller May 21, 2026 15:22
@Zaimwa9 Zaimwa9 merged commit 2be8504 into main May 22, 2026
33 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/experimentation-external-snowflake-warehouse-api-clean branch May 22, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants