feat(experimentation): Snowflake warehouse frontend by Zaimwa9 · Pull Request #7566 · Flagsmith/flagsmith

Zaimwa9 · 2026-05-21T15:24:58Z

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Frontend

Add Snowflake connection drawer form (CreateWarehouseConnectionModal) with edit mode support
Replace trash button with three-dot action menu (Edit + Delete for external warehouses, Delete only for Flagsmith)
Show warehouse type in card title for external connections (e.g. "My Snowflake (Snowflake)")
Add updateWarehouseConnection PATCH mutation in RTK Query service
Narrower side-modal variant (side-modal--narrow, 640px)
Layout: Flagsmith toggle and external warehouse section separated with visual spacing
Save button disabled in edit mode until changes are made
Error state when warehouse connections fail to load

How did you test this code?

npm run typecheck — clean
Create snowflake connection via drawer form → card appears with type label
Three-dot menu on snowflake card → Edit and Delete options
Three-dot menu on flagsmith card → Delete only
Edit snowflake → form pre-filled, save disabled until change, save updates connection
Delete connection → confirm dialog → connection removed
No connections → "Connect an external Warehouse" section visible
Has connections → "Configure a warehouse" button top-right

…alue

…ctions

…imentation-warehouse-setup-frontend

…tion menu, edit support

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

vercel · 2026-05-21T15:25:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ready	Preview, Comment	May 22, 2026 9:24am
flagsmith-frontend-staging	Ready	Preview, Comment	May 22, 2026 9:24am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	May 22, 2026 9:24am

github-actions · 2026-05-21T15:27:00Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api-test:pr-7566`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-e2e:pr-7566`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-7566`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7566`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7566`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-7566`	Finished ✅	Results ✅

github-actions · 2026-05-21T15:33:18Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
38.3 seconds
7651d68
🔄 Run: #16895 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
36.4 seconds
7651d68
🔄 Run: #16895 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
49.2 seconds
7651d68
🔄 Run: #16895 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 6 seconds
7651d68
🔄 Run: #16895 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
38.3 seconds
00b18b8
🔄 Run: #16906 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
32.5 seconds
00b18b8
🔄 Run: #16906 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
53.8 seconds
00b18b8
🔄 Run: #16906 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

3 passed

Details

3 tests across 3 suites
41.3 seconds
00b18b8
🔄 Run: #16906 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
38.1 seconds
0817d08
🔄 Run: #16907 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
38.9 seconds
0817d08
🔄 Run: #16907 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

3 passed

Details

3 tests across 3 suites
42.9 seconds
0817d08
🔄 Run: #16907 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
58.5 seconds
0817d08
🔄 Run: #16907 (attempt 1)

github-actions · 2026-05-21T15:35:03Z

Visual Regression

19 screenshots compared. See report for details.
View full report

Zaimwa9 · 2026-05-22T09:12:30Z

@gemini-code-assist review please

gemini-code-assist

Code Review

This pull request adds support for creating and updating external warehouse connections, specifically Snowflake. It includes new API mutations, updated TypeScript types, and a new modal for connection management. The warehouse tab UI has been updated to handle multiple connections and an edit workflow. Feedback points out hardcoded placeholder statistics, invalid HTML from nested buttons in the connection cards, and the potentially accidental removal of SCIM configuration types.

I am having trouble creating individual review comments. Click here to see my feedback.

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/WarehouseConnectionCard.tsx (93-103)

The statistics (lastEventReceived, totalEventsReceived, uniqueEventsCount) and the SQL query string are currently hardcoded with placeholder values (e.g., '19 May 2026', 'SELECT * FROM users'). These should be dynamically populated from the connection data or handled as empty/loading states if the data is not yet available from the API.

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/WarehouseConnectionCard.tsx (136-145)

The Button component (which renders a <button> tag) is nested inside another <button> (the accordion header at line 109). Nesting interactive elements like buttons is invalid HTML and can cause issues with event propagation and accessibility. Consider changing the outer <button> to a <div> and handling the click event there.

frontend/common/types/requests.ts (737-740)

SCIM configuration request types are being removed here. This change is not mentioned in the PR description and seems unrelated to the Snowflake warehouse feature. Please verify if this deletion was intentional or an accidental result of a merge conflict.

Zaimwa9 · 2026-05-22T09:59:26Z

Fixed

SCIM configuration request types are being removed here. This change is not mentioned in the PR description and seems unrelated to the Snowflake warehouse feature. Please verify if this deletion was intentional or an accidental result of a merge conflict.

2 other comments are discardable

talissoncosta · 2026-05-22T12:02:05Z

+                setMenuOpen(!menuOpen)
+              }}
+            >
+              <Icon name='more-vertical' width={16} fill='#656D7B' />


Can you please check if we really need those hardcoded colours ?

Zaimwa9 added 13 commits May 19, 2026 15:46

feat: add-warehouse-connection-types-and-rtk-query-service

b548c24

feat: add-warehouse-tab-components-for-environment-settings

59dc25c

feat: gate-warehouse-tab-with-plan-based-permission-and-remote-flag-v…

0bfec19

…alue

fix: allow-dropdown-overflow-in-collapsible-sections-once-fully-expanded

6e83c9d

feat: update frontend for list-based warehouse connections endpoint

76703f5

feat: added hardcoded stats

e0867f9

feat: restructured cleanly new components

5b694af

feat: added plan based banner for upgrade

b419979

fix: use uuid to delete single connection in endpoint

415c150

feat(experimentation): support id instead of uuid for warehouse conne…

7c5e698

…ctions

Merge branch 'main' of github.com:Flagsmith/flagsmith into feat/exper…

3d21aab

…imentation-warehouse-setup-frontend

feat(experimentation): added error state on get failure

40a91f0

feat(experimentation): Snowflake warehouse frontend — drawer form, ac…

7651d68

…tion menu, edit support

Zaimwa9 requested a review from a team as a code owner May 21, 2026 15:24

Zaimwa9 requested review from talissoncosta and removed request for a team May 21, 2026 15:25

claude Bot reviewed May 21, 2026

View reviewed changes

vercel Bot deployed to Preview – flagsmith-frontend-preview May 21, 2026 15:25 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging May 21, 2026 15:25 View deployment

github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels May 21, 2026

Zaimwa9 requested a review from gagantrivedi May 21, 2026 15:38

Base automatically changed from feat/experimentation-warehouse-setup-frontend to main May 22, 2026 08:58

feat(experimentation): rebased main

00b18b8

vercel Bot deployed to Preview – docs May 22, 2026 09:09 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging May 22, 2026 09:09 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview May 22, 2026 09:09 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels May 22, 2026

gemini-code-assist Bot reviewed May 22, 2026

View reviewed changes

feat(experimentation): re-introduced scim configuration types

0817d08

vercel Bot deployed to Preview – flagsmith-frontend-staging May 22, 2026 09:23 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview May 22, 2026 09:24 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels May 22, 2026

gagantrivedi approved these changes May 22, 2026

View reviewed changes

Zaimwa9 merged commit 8545240 into main May 22, 2026
29 checks passed

Zaimwa9 deleted the feat/experimentation-external-snowflake-frontend branch May 22, 2026 11:42

flagsmithdev mentioned this pull request May 22, 2026

chore(main): release 2.235.0 #7561

Open

talissoncosta reviewed May 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(experimentation): Snowflake warehouse frontend#7566

feat(experimentation): Snowflake warehouse frontend#7566
Zaimwa9 merged 15 commits into
mainfrom
feat/experimentation-external-snowflake-frontend

Zaimwa9 commented May 21, 2026 •

edited

Loading

Uh oh!

claude Bot left a comment

Uh oh!

vercel Bot commented May 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 21, 2026 •

edited

Loading

Uh oh!

Zaimwa9 commented May 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Zaimwa9 commented May 22, 2026

Uh oh!

Uh oh!

talissoncosta May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Zaimwa9 commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Frontend

How did you test this code?

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

vercel Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

github-actions Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

github-actions Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

Zaimwa9 commented May 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/WarehouseConnectionCard.tsx (93-103)

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/WarehouseConnectionCard.tsx (136-145)

frontend/common/types/requests.ts (737-740)

Uh oh!

Zaimwa9 commented May 22, 2026

Uh oh!

Uh oh!

talissoncosta May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Zaimwa9 commented May 21, 2026 •

edited

Loading

vercel Bot commented May 21, 2026 •

edited

Loading

github-actions Bot commented May 21, 2026 •

edited

Loading

github-actions Bot commented May 21, 2026 •

edited

Loading

github-actions Bot commented May 21, 2026 •

edited

Loading