feat(experiment): add experiments list page with filtering, pagination, and actions#7628
Merged
Conversation
…nd use hooks to set timestamps
…th bordered cards
…and proper styling
…eature list query
…gn and update ReviewStep
… fix review layout and table styling
Zaimwa9
commented
May 28, 2026
Contributor
Author
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request updates the UI patterns documentation and introduces comprehensive pagination, filtering, and action controls for the experiments list, including new endpoints for starting, pausing, completing, and deleting experiments. The review feedback highlights several critical issues that will cause compilation errors or runtime crashes, such as missing imports across multiple files, incorrect event typing, missing closeModal calls in confirmation dialogs, and unsafe property access on potentially nullable feature objects.
Contributor
talissoncosta
left a comment
There was a problem hiding this comment.
left some suggestions, thanks for handling that @Zaimwa9
talissoncosta
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
ExperimentsListControls— tab filter (All / Running / Draft / Paused / Completed) withstatus_countsand search barExperimentsTable— name, linked flag, status badge, variation count, last updated, actions dropdownStatusBadge— coloured pill per experiment statusExperimentActionDropdown— Start / Pause / Complete / Delete with confirmation modalsuseGetExperimentsQueryto supportpage,page_size,status,qwithtransformCorePagingExperiment.featurefromnumbertoExperimentFeature(full object); typedExperimentFeature.typeasFeatureTypeExperimentStatusCountsandstatus_countsto paginated response typeexperiments/constants.tsComponentName/{tsx,scss,index.ts}folder structure<InputGroup>(finishing feat(experimentation): add experiment creation wizard frontend #7596 cleanup)useMemo→useCallback, NaN-safereduceonstatus_counts, Paging hidden when emptyui-patterns.md: corrected Tabs path, documenteddestructiveonopenConfirmHow did you test this code?
ENV=local npm run devtsc --noEmitandeslintpass on all touched files