Skip to content

feat(experiment): use backend type filter for multivariate features#7630

Merged
Zaimwa9 merged 3 commits into
mainfrom
feat/experiment-wizard-mv-variants-from-api
May 29, 2026
Merged

feat(experiment): use backend type filter for multivariate features#7630
Zaimwa9 merged 3 commits into
mainfrom
feat/experiment-wizard-mv-variants-from-api

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented May 28, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #7596

  • Use backend type=MULTIVARIATE query param instead of client-side filtering in the experiment wizard feature select — fixes pagination issues where multivariate flags on later pages were invisible
  • Attach full ProjectFlag object to Select options, removing the .find() lookup that could hit race conditions during search
  • Disable react-select client-side filtering since results are already server-filtered
  • Add Storybook stories for VariationTable and ContentCard components

How did you test this code?

  • Open experiment creation wizard, confirm feature select only shows multivariate flags
  • Type in the select — verify server-side search works (debounced)
  • Select a feature — verify variation table renders correctly
  • Run Storybook and check VariationTable and ContentCard stories render

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner May 28, 2026 15:07
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team May 28, 2026 15:07
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment May 28, 2026 3:48pm
flagsmith-frontend-staging Ready Ready Preview, Comment May 28, 2026 3:48pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 28, 2026 3:48pm

Request Review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the feature list query to filter by FeatureType on the server side, specifically fetching only multivariate features for the experiment setup step. It also simplifies the selection logic in SetupStep.tsx and adds Storybook stories for ContentCard and VariationTable. Feedback is provided regarding the filterOption prop in react-select, which is currently typed and implemented incorrectly; it should be updated to () => true to cleanly disable client-side filtering.

Comment thread frontend/web/components/experiments/steps/SetupStep.tsx Outdated
@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7630 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7630 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-7630 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-7630 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7630 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7630 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.8 seconds
commit  549ba70
info  🔄 Run: #17082 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.3 seconds
commit  549ba70
info  🔄 Run: #17082 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  36.5 seconds
commit  549ba70
info  🔄 Run: #17082 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 4 seconds
commit  549ba70
info  🔄 Run: #17082 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.8 seconds
commit  07cbfeb
info  🔄 Run: #17084 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.9 seconds
commit  07cbfeb
info  🔄 Run: #17084 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  31.9 seconds
commit  07cbfeb
info  🔄 Run: #17084 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  39.9 seconds
commit  07cbfeb
info  🔄 Run: #17084 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.5 seconds
commit  0c220df
info  🔄 Run: #17087 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.1 seconds
commit  0c220df
info  🔄 Run: #17087 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  35.1 seconds
commit  0c220df
info  🔄 Run: #17087 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  52.6 seconds
commit  0c220df
info  🔄 Run: #17087 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Visual Regression

19 screenshots compared. See report for details.
View full report

Comment thread frontend/documentation/components/ContentCard.stories.tsx Outdated
Comment thread frontend/documentation/components/VariationTable.stories.tsx
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling that! Looks great!

@Zaimwa9 Zaimwa9 merged commit 164d4bc into main May 29, 2026
28 of 29 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/experiment-wizard-mv-variants-from-api branch May 29, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants