feat(experiment): use backend type filter for multivariate features#7630
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request updates the feature list query to filter by FeatureType on the server side, specifically fetching only multivariate features for the experiment setup step. It also simplifies the selection logic in SetupStep.tsx and adds Storybook stories for ContentCard and VariationTable. Feedback is provided regarding the filterOption prop in react-select, which is currently typed and implemented incorrectly; it should be updated to () => true to cleanly disable client-side filtering.
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
talissoncosta
left a comment
There was a problem hiding this comment.
Thanks for handling that! Looks great!
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7596
type=MULTIVARIATEquery param instead of client-side filtering in the experiment wizard feature select — fixes pagination issues where multivariate flags on later pages were invisibleProjectFlagobject to Select options, removing the.find()lookup that could hit race conditions during searchVariationTableandContentCardcomponentsHow did you test this code?