Skip to content

feat(Segment Membership): Recount after identity delete#7933

Merged
khvn26 merged 4 commits into
mainfrom
feat/segment-membership-delete-recount
Jul 1, 2026
Merged

feat(Segment Membership): Recount after identity delete#7933
khvn26 merged 4 commits into
mainfrom
feat/segment-membership-delete-recount

Conversation

@khvn26

@khvn26 khvn26 commented Jul 1, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #7593.

In this PR, we trigger segment count refresh when an identity is deleted in UI.

How did you test this code?

Added unit tests. Will test E2E in staging.

@khvn26
feat(Segment Membership): Recount after identity delete
88bbb11 
Deleting an Edge identity now schedules a per-project segment membership
recount, delayed by the Edge CDC SLO so the recount reads ClickHouse after
the is_deleted tombstone lands. The tombstone write itself is owned by CDC.

beep boop
@vercel

vercel Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 1, 2026 6:44pm
flagsmith-frontend-preview Ignored Ignored Preview Jul 1, 2026 6:44pm
flagsmith-frontend-staging Ignored Ignored Preview Jul 1, 2026 6:44pm

Request Review

@khvn26 khvn26 requested review from a team as code owners July 1, 2026 17:53
@khvn26 khvn26 requested review from emyller and removed request for a team July 1, 2026 17:53
@github-actions github-actions Bot added api Issue related to the REST API docs Documentation updates feature New feature or request and removed docs Documentation updates labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7933 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7933 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7933 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7933 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-7933 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7933 Finished ✅ Results ✅

@github-actions github-actions Bot added the docs Documentation updates label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  45 seconds
commit  88bbb11
info  🔄 Run: #18009 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  41.8 seconds
commit  88bbb11
info  🔄 Run: #18009 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  55.5 seconds
commit  88bbb11
info  🔄 Run: #18009 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  12 seconds
commit  88bbb11
info  🔄 Run: #18009 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 3 suites
duration  35 seconds
commit  0d44497
info  🔄 Run: #18010 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  5 passed

Details

stats  5 tests across 3 suites
duration  46.1 seconds
commit  0d44497
info  🔄 Run: #18010 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  42.8 seconds
commit  0d44497
info  🔄 Run: #18010 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  42.7 seconds
commit  0d44497
info  🔄 Run: #18010 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  34.6 seconds
commit  2f5ac04
info  🔄 Run: #18011 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  50.7 seconds
commit  2f5ac04
info  🔄 Run: #18011 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 3 suites
duration  38.2 seconds
commit  2f5ac04
info  🔄 Run: #18011 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  5 passed

Details

stats  5 tests across 5 suites
duration  45.3 seconds
commit  2f5ac04
info  🔄 Run: #18011 (attempt 1)

@github-actions

github-actions Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request docs Documentation updates labels Jul 1, 2026
emyller
emyller reviewed Jul 1, 2026
View reviewed changes

@emyller emyller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM.

Comment thread api/app/settings/common.py
@khvn26 khvn26 requested a review from emyller July 1, 2026 18:44
@github-actions github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jul 1, 2026
emyller
emyller approved these changes Jul 1, 2026
View reviewed changes

@emyller emyller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (c9a5f54) to head (2f5ac04).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7933   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files        1497     1497           
  Lines       59065    59141   +76     
=======================================
+ Hits        58259    58335   +76     
  Misses        806      806

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 merged commit b8b25c1 into main Jul 1, 2026
33 checks passed
@khvn26 khvn26 deleted the feat/segment-membership-delete-recount branch July 1, 2026 18:57
@flagsmith-engineering flagsmith-engineering Bot mentioned this pull request Jul 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyller emyller emyller approved these changes

Assignees

@emyller emyller

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle is_deleted attribute when querying for identities in ClickHouse

2 participants

@khvn26 @emyller