Skip to content

feat: improve experiment recommendation and disable Snowflake warehouse#7940

Merged
Zaimwa9 merged 3 commits into
mainfrom
feat/experimentation-recommandation-and-disable-snowflake
Jul 2, 2026
Merged

feat: improve experiment recommendation and disable Snowflake warehouse#7940
Zaimwa9 merged 3 commits into
mainfrom
feat/experimentation-recommandation-and-disable-snowflake

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Disable Snowflake warehouse card with a "Coming Soon" badge (matching BigQuery/Databricks)
  • Extract experiment recommendation into its own component (ExperimentRecommendation) with VariantName for colour swatches
  • Move recommendation between Hypothesis and configuration cards for better visibility
  • Increase recommendation font size from 14px to 16px
  • Improve copy: title shows probability ("80% Winner Probability Confirmed"), body includes lift %, actionable call-to-action

How did you test this code?

Manually verified both changes in the browser.

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner July 2, 2026 12:14
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team July 2, 2026 12:14
@vercel

vercel Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jul 2, 2026 2:38pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jul 2, 2026 2:38pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 2, 2026 2:38pm

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7940 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7940 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-7940 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-7940 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7940 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7940 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  37.6 seconds
commit  9f0e250
info  🔄 Run: #18025 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  42.7 seconds
commit  9f0e250
info  🔄 Run: #18025 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  17.6 seconds
commit  9f0e250
info  🔄 Run: #18025 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  4.2 seconds
commit  9f0e250
info  🔄 Run: #18025 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  54.2 seconds
commit  47d0a34
info  🔄 Run: #18034 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 5 suites
duration  32.1 seconds
commit  47d0a34
info  🔄 Run: #18034 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  11.4 seconds
commit  47d0a34
info  🔄 Run: #18034 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  42.9 seconds
commit  47d0a34
info  🔄 Run: #18034 (attempt 1)

@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

talissoncosta
talissoncosta requested changes Jul 2, 2026
View reviewed changes

@talissoncosta talissoncosta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! can you just check if you can use ColorSwatch instead of a building an one off dot component ?

Comment thread frontend/web/components/experiments/results/VariantName.tsx Outdated
Comment thread frontend/web/components/experiments/results/ExperimentRecommendation.tsx Outdated
talissoncosta
talissoncosta approved these changes Jul 2, 2026
View reviewed changes

@talissoncosta talissoncosta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the changes! Looks great!

@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2026
@Zaimwa9 Zaimwa9 merged commit 31c9dc9 into main Jul 2, 2026
30 of 31 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/experimentation-recommandation-and-disable-snowflake branch July 2, 2026 14:51
@flagsmith-engineering flagsmith-engineering Bot mentioned this pull request Jul 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talissoncosta talissoncosta talissoncosta approved these changes

Assignees

No one assigned

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zaimwa9 @talissoncosta