Passing single object rather than series of params #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 7, 2021 15:10
|
This pull request is being automatically deployed with Vercel (learn more). react-native-performance-monitor – ./lib🔍 Inspect: https://vercel.com/flagsmith/react-native-performance-monitor/BD6vLdQapWU6U3quVEGVV6M1W8tf |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
Hmm, I do like this idea but it's a breaking change so would have to be a major version bump. The code looks good to me, I'll merge it and bump the version accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey great library. I have been using it and i wanted to make some improvements according to my use case but before doing that i wanted to improve readability. Instead of passing multiple parameters i switched to sending single object which i believe improves readability, as it stated in this issue as well #22
If there is anything want to be changed please write me.