Fix: include belief time in fixed-value records for chart data#2147
Fix: include belief time in fixed-value records for chart data#2147joshuaunity wants to merge 9 commits intomainfrom
Conversation
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
|
NOTE: Changelog entry needed |
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
|
Manual tests passed. one thing i couldn't get to work is the panning feature but i don't know if that's in the scope of this pr. |
No its not. There is no panning to this work |
|
@BelhsanHmida, are there any other findings? |
| "bt": belief_time_ms, | ||
| "sf": 1.0, | ||
| "src": source_id, | ||
| "bh": 0, |
There was a problem hiding this comment.
Small consistency concern: fixed-value records now get belief_time / bt set to the chart start, which makes sense for replay because the values should be visible from the first tick. But they still emit belief_horizon / bh as 0 for every generated timestamp.
For later timestamps, that makes the timing metadata a bit inconsistent: the record says it was known at the chart start, but also reports a zero horizon. Since replay only depends on belief_time / bt, could we either omit belief_horizon / bh for these synthetic fixed-value records, or compute it per timestamp if we want to keep the field?
@Flix6x do you see a case where we would need belief_horizon on these synthetic fixed-value sensors?
here are my reviews. i forgot to press submit review |
Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>
|
Could you ask Copilot to add a test case for this? We usually like to add coverage on most PRs, especially now that AI makes it cheaper to include. |
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
…es/flexmeasures into fix/disapearring-graph-values
Hmm, we can add a guard. What do you think @Flix6x would it be better off as is currently? From my perspective, there doesn't seem to be a case where one would need multiple of the same thing. |
No, indeed. There should be no reason for having duplicate flex-config references in the same subchart. That also goes for sensors, actually. However, it should remain possible to use the same sensor or flex-config reference in different subcharts. |
…d improve sensor addition checks Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Description
This PR resolves an issue where fixed values in graphs were not displayed during playback. These values are now visible.
Look & Feel
Before:

After:

How to test
Further Improvements
None
Related Items
This PR closes #2110
Sign-off