Skip to content

Fix: All use of raw json when updating flex_configs#2149

Closed
joshuaunity wants to merge 11 commits into
mainfrom
fix/asset-patch-accept-json-object-flex-context
Closed

Fix: All use of raw json when updating flex_configs#2149
joshuaunity wants to merge 11 commits into
mainfrom
fix/asset-patch-accept-json-object-flex-context

Conversation

@joshuaunity
Copy link
Copy Markdown
Contributor

@joshuaunity joshuaunity commented May 5, 2026 •
edited
Loading

Description

In this PR i fixed a bug where RAW JSON had to be loaded before it can be parsed as a flex-config. These forced users to take extra steps just to modify flex-configs

Look & Feel

Before
image

After
image

How to test

I noticed i didn't experience this issue while use a http client like "insomnia" you'll probably also not experience it if you use POSTMAN as well. But rather running it though a python script reveals the issue.

Use this script for testing

import requests

token = "xxxxxxxxxxxxxxxxxxxxxxxx"

res = requests.patch("http://localhost:5000/api/v3_0/assets/<asset_id>",
    headers = {
        "Authorization": <token>,
    },
    json={
        "flex_context":
        {
            "site-power-capacity":"1000 kW"
        }
    }
)
print(res.text)

Further Improvements

None

Related Items

This PR closes #2144

Sign-off

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@joshuaunity
Fix: add test for PATCH endpoint to accept flex context JSON object
93bb81a 
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
@joshuaunity joshuaunity self-assigned this May 5, 2026
@joshuaunity
Update API version to 0.32.0
2dd9106 
Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>
@nhoening nhoening changed the title Fix: All use of raw json when updating flex_confgs Fix: All use of raw json when updating flex_configs May 5, 2026
@joshuaunity joshuaunity requested a review from nhoening May 12, 2026 07:32
@joshuaunity
chore: add changelog entry
4d1da04 
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
@joshuaunity
chore: modify chnagelog
f9546f5 
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
@nhoening nhoening added this to the 0.33.0 milestone May 12, 2026
joshuaunity and others added 3 commits May 12, 2026 09:00
@joshuaunity
Merge branch 'main' into fix/asset-patch-accept-json-object-flex-context
8058bc3 
Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>
@Flix6x
refactor: use fresh_db fixture in fresh_db test module
98075a5 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: double check that the flex_context was empty before the patch
b8dcfd0 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Flix6x
Flix6x requested changes May 12, 2026
View reviewed changes
Comment thread documentation/changelog.rst Outdated
Comment on lines +45 to +47
* Make the sensor page load much faster for sensors with lots of data, by avoiding to load statistics over all of its history by default [see `PR #2129 <https://www.github.com/FlexMeasures/flexmeasures/pull/2129>`_]
* Return a clear validation error (instead of a server ZeroDivisionError) when posting instantaneous (0-minute) data to non-instantaneous sensors via ``[POST] /sensors/(id)/data`` [see `PR #2116 <https://www.github.com/FlexMeasures/flexmeasures/pull/2116>`_]
* Fix asset context page for asset names containing apostrophes [see `PR #2117 <https://www.github.com/FlexMeasures/flexmeasures/pull/2117>`_]
Copy link
Copy Markdown
Member

@Flix6x Flix6x May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this PR.

Copy link
Copy Markdown
Contributor Author

@joshuaunity joshuaunity May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some conflicts. i checked on main and saw that these list are under 0.32.1 so i moved them here as well

Copy link
Copy Markdown
Contributor Author

@joshuaunity joshuaunity May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill revert

@joshuaunity
chore: modify chagelog
b0189ab 
Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
@joshuaunity
Merge branch 'fix/asset-patch-accept-json-object-flex-context' of git…
3e72b86 
…hub.com:FlexMeasures/flexmeasures into fix/asset-patch-accept-json-object-flex-context

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 12, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedpsycopg2-binary@​2.9.12 ⏵ 2.9.1110010010010070
Updatedmypy@​1.20.2 ⏵ 1.20.175100100100100
Updatedpandas@​2.3.3 ⏵ 2.2.176100100100100
Updatedsentry-sdk@​2.59.0 ⏵ 2.58.094100100100100
Updatedpoethepoet@​0.45.0 ⏵ 0.44.097100100100100
Updatedflask-swagger-ui@​5.32.5 ⏵ 5.32.298100100100100
Updatedu8darts@​0.41.0 ⏵ 0.40.098 -2100100 +11100100
Updatedaltair@​6.1.0 ⏵ 6.0.099100100100100
Updatedpackaging@​26.2 ⏵ 26.199100100100100
Updatedpydantic@​2.13.3 ⏵ 2.13.2100100100100100
Updatedpytz@​2026.2 ⏵ 2026.1.post1100100100100100
Updatedflask-wtf@​1.3.0 ⏵ 1.2.2100100100100100
Updatedpyopenssl@​26.1.0 ⏵ 26.0.0100100100100100
Updatedcryptography@​47.0.0 ⏵ 46.0.7100100100100100
Updatedtimely-beliefs@​3.5.5 ⏵ 3.5.4100100100100100
Updatedtypes-requests@​2.33.0.20260503 ⏵ 2.33.0.20260408100100100100100

View full report

@joshuaunity
Copy link
Copy Markdown
Contributor Author

joshuaunity commented May 12, 2026

i thnk ill need to recreate this PR

Flix6x added 2 commits May 12, 2026 12:05
@Flix6x
Revert "Merge branch 'fix/asset-patch-accept-json-object-flex-context…
f735ef1 
…' of github.com:FlexMeasures/flexmeasures into fix/asset-patch-accept-json-object-flex-context"

This reverts commit 3e72b86, reversing
changes made to b0189ab.
@Flix6x
Revert "chore: modify chagelog"
0fc50b0 
This reverts commit b0189ab, reversing
changes made to f9546f5.
@joshuaunity
Copy link
Copy Markdown
Contributor Author

joshuaunity commented May 12, 2026

New PR in 2162.

illbe closing this PR

@joshuaunity joshuaunity reopened this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flix6x Flix6x Flix6x requested changes

@nhoening nhoening Awaiting requested review from nhoening

Assignees

@joshuaunity joshuaunity

Labels

None yet

Projects

None yet

Milestone

0.33.0

Development

Successfully merging this pull request may close these issues.

JSON formatting problems when patching asset.flex_context via API

3 participants

@joshuaunity @Flix6x @nhoening