Skip to content

Fix/sensor data deletion window#2175

Merged
Flix6x merged 10 commits into
mainfrom
fix/sensor-data-deletion-window
May 15, 2026
Merged

Fix/sensor data deletion window#2175
Flix6x merged 10 commits into
mainfrom
fix/sensor-data-deletion-window

Conversation

@Flix6x
Copy link
Copy Markdown
Contributor

@Flix6x Flix6x commented May 14, 2026 •
edited
Loading

Description

  • Fix off-by-one error on data deletion windows
  • Internal refactoring to use schema; improve exposure of fields in Swagger
  • Added changelog item in documentation/changelog.rst

Look & Feel

  • The deletion window would leave the last event.
  • Now a single belief on an instantaneous sensor can be removed as well.

How to test

...

Further Improvements

  • I'm proposing to make this a patch release, because the data deletion button was introduced in v0.32.0.
  • Within this PR I am also proposing to backport the auth issue for the account page. Account attributes were introduced in 0.32.0, and we know that hosts are considering to use it to store secrets, so for me it would make sense that it is fixed with a patch version.
  • The second fix would be kind of a bonus. It is part of the same PR (Fix auth issues: child asset creation, account page access #2163), and we were already hoping to get it released soon.

Related Items

...

Flix6x added 6 commits May 14, 2026 15:28
@Flix6x
refactor: move to DeleteSensorDataSchema
42f9bb7 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: validation on start and until
25961d7 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
add
e629273 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
docs: update field description
0b2ba81 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
feat: add test coverage
3793938 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
fix: deleting a single datapoint for instantaneous sensors
c517e20 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x Flix6x added this to the 0.33.0 milestone May 14, 2026
@Flix6x Flix6x self-assigned this May 14, 2026
@Flix6x Flix6x added the bug Something isn't working label May 14, 2026
Flix6x added 4 commits May 14, 2026 21:12
@Flix6x
Merge remote-tracking branch 'origin/main' into fix/sensor-data-delet…
4364f46 
…ion-window
@Flix6x
docs: mitigating circumstances (only the recently introduced account …
cc0eda3 
…attributes were exposed)

Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
docs: changelog entry
1e41248 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
docs: reassign several fixes from v0.33.0 to v0.32.3
b0e17c7 
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x Flix6x added documentation Improvements or additions to documentation UI Data API and removed documentation Improvements or additions to documentation labels May 14, 2026
@Flix6x Flix6x modified the milestones: 0.33.0, 0.32.3 May 14, 2026
@Flix6x Flix6x requested a review from nhoening May 14, 2026 21:41
nhoening
nhoening approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested regular deletion, which works.
Code looks okay.

@Flix6x Flix6x merged commit 05b976d into main May 15, 2026
12 checks passed
@Flix6x Flix6x deleted the fix/sensor-data-deletion-window branch May 15, 2026 07:44
Flix6x added a commit that referenced this pull request May 15, 2026
@Flix6x
Backport PR #2175: Fix/sensor data deletion window (#2175)
aeb4daf 
* refactor: move to DeleteSensorDataSchema

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* feat: validation on start and until

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* add

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: update field description

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* feat: add test coverage

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: deleting a single datapoint for instantaneous sensors

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: mitigating circumstances (only the recently introduced account attributes were exposed)

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: reassign several fixes from v0.33.0 to v0.32.3

Signed-off-by: F.N. Claessen <claessen@seita.nl>

---------

Signed-off-by: F.N. Claessen <claessen@seita.nl>

(cherry picked from commit 05b976d)
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels

API bug Something isn't working Data UI

Projects

None yet

Milestone

0.32.3

Development

Successfully merging this pull request may close these issues.

2 participants

@Flix6x @nhoening