Feat: Create Accounts on UI by joshuaunity · Pull Request #2176 · FlexMeasures/flexmeasures

joshuaunity · 2026-05-15T07:39:33Z

Description

Implements account creation for admins and consultants, both via API and UI.

API (POST /api/v3_0/accounts):

Added new POST /api/v3_0/accounts endpoint
Added AccountCreateSchema with name (required), primary_color, secondary_color
Validation: unique account names and non-empty values
Added FlexMeasuresPlatform virtual resource in auth/policy.py for top-level create-children permission checks
Admins can create accounts freely; consultants can create accounts when their account has the CONSULTANT_WITH_OWN_CLIENTS role — the new account is automatically linked to the consultant's account
API tests covering successful creation and auth failures

UI:
"Create account" button added to /accounts page (visible only to authorised users)
New account creation form at /accounts/create with name field and colour pickers for primary and secondary brand colours
UI tests for the account creation flow

Changelog entry added in documentation/changelog.rst

How to test

Log in as an admin or as a consultant whose account has the CONSULTANT_WITH_OWN_CLIENTS role
Navigate to/accounts— a "Create account" button should appear
Click through to the form, fill in a name and optional brand colours, and submit

Or run automated tests:

pytest flexmeasures/api/v3_0/tests/test_accounts_api.py
pytest flexmeasures/ui/tests/test_account_crud.py

Related Items

Closes #1869

Sign-off

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

…ation Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…pty values Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…, pipeline config isolation patterns Context: - PR #2176 introduced _AnnotationRegressorProxy for reusing sensor-based pipeline utilities with non-sensor (annotation) data, and added query_account_annotations mirroring query_asset_annotations Change: - Added lesson on duck-type proxy validity check (only proxy what's actually accessed) - Added annotation query parity rule (account + asset variants must stay consistent) - Added pipeline config schema isolation guidance (pipeline vs search vs reporter schemas) - Added _clean_parameters retention decision rule for new config keys Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

… pipeline conventions Context: - PR #2176 added --timezone option to holiday CLI commands and implements annotation-to-pipeline loading that must match load_data_all_beliefs UTC-naive convention Change: - Added lesson on --timezone recommendation for holiday CLI commands - Added UTC-naive convention for annotation timestamp loading into pipeline - Added DST boundary risk note for full-day annotations spanning spring-forward Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

…ta_key as API surface Context: - PR #2176 added future-annotation-regressors as an optional pipeline config field using load_default=[] and data_key kebab-case pattern Change: - Added lesson on load_default=[] as backward compatibility pattern for new optional fields - Added lesson on _clean_parameters not being a regression risk for new config keys - Added lesson that data_key kebab-case is the API surface (not Python attribute name) Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

…e review Context: - Post-session governance review of annotation regressors feature branch - Single-agent execution (recurring delegation failure), but high code quality Change: - Documented delegation observation (all commits by copilot-swe-agent) - Documented new patterns added to 3 specialist agents - Noted open question: missing account_id/asset_id spec causes silent degradation (could be a schema-level validation error in future) - Noted storage growth concern for future_annotation_regressors in DataSource attrs Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/5a54d4cf-b1e6-4400-8808-8fe704b3fd84 Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

joshuaunity · 2026-05-15T12:41:39Z

@copilot, please update the PR description to reflect the changes in relation to issue #1869, while preserving the existing description structure.

Copilot · 2026-05-15T12:44:37Z

@copilot, please update the PR description to reflect the changes in relation to issue #1869, while preserving the existing description structure.

Updated the PR description to reflect the changes in relation to issue #1869. The description now covers the new POST /api/v3_0/accounts API endpoint, the FlexMeasuresPlatform permission resource, the UI form with colour pickers, validation, auth rules, tests, and the changelog entry — while preserving the existing structure.

…creation Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/e49db96c-1da8-4a18-91ab-fc630290d726 Co-authored-by: joshuaunity <45713692+joshuaunity@users.noreply.github.com>

nhoening · 2026-05-15T13:02:21Z

@copilot, please update the PR description to reflect the changes in relation to issue #1869, while preserving the existing description structure.

Updated the PR description to reflect the changes in relation to issue #1869. The description now covers the new POST /api/v3_0/accounts API endpoint, the FlexMeasuresPlatform permission resource, the UI form with colour pickers, validation, auth rules, tests, and the changelog entry — while preserving the existing structure.

I believe copilot only updated the changelog.

nhoening

High-level review of early state. Solid start!

I identified some things in auth and the form/API I would change. I will look into account roles, in order to help.

Add a button to "Add client account" on the account page (if the account has the role for that or user is a site admin).

This PR should also uodate this section when it is done.

nhoening · 2026-05-15T12:07:23Z

 ADMIN_READER_ROLE = "admin-reader"
 ACCOUNT_ADMIN_ROLE = "account-admin"
 CONSULTANT_ROLE = "consultant"
+CONSULTANT_WITH_OWN_CLIENTS_ACCOUNT_ROLE = "CONSULTANT_WITH_OWN_CLIENTS"


I believe you mean this role to be an account role, while the list here are user roles.
So as a first step, make sure there are two lists of roles being distinguished here.

Read more here. I believe account roles are a bit underdocumented at the moment. That could be a TODO for me: Find out which roles we actuall do support. Your new role can be one of them.

And they cannot be edited in the UI also. Is it easy to do so, by copying the way we do that in the user edit form?

The name also should not be all-caps.

From my checks, there weren't any prominent account roles we support. In most cases, I found the use was with dummy data and tests.

I updated the security docs to distinguish between roles with built-in core behavior and roles that are just examples/test fixtures. From the current code, Consultancy is the only clearly built-in account role, MDC is referenced by the core auth model, and roles like Prosumer, Supplier, ConsultancyClient are mainly fixture/example roles.

Yes, as I said, I should do that research (I had similar conclusions) and maybe propose how to phrase this.
I have some ideas about a 2nd account role we could officially support, will open a discussion.

Would editable account roles (for admins) be rather straightforward?

nhoening · 2026-05-15T13:00:05Z

+
+        try:
+            db.session.commit()
+        except IntegrityError:


I believe this error handling is not needed - we have error handlers.

Or do you see a reason?

I think we should keep it for now. The shared error handlers format the response, but they do not rollback the SQLAlchemy session for a generic IntegrityError here. So without this local handling, a failed account create can leave the session in a broken state. If we want to remove it, we would need to first centralize rollback in the shared IntegrityError handler.

What about this part in our central rollback handler (see transactional.py)?

def after_request_exception_rollback_session(exception): """...""" if exception is not None: db.session.rollback() return

It is registerd on the app for all requests:

app.teardown_request(after_request_exception_rollback_session)

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…ncy input to account creation form Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…ancy accounts and improve account selection logic Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…n UI Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…ement in UI Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…xmeasures into feat/creata-accounts-UI Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

…urity documentation Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity · 2026-05-18T14:56:20Z

This PR should also uodate this section when it is done.

I've updated this, it's ready for review as well. Let me know your thoughts and if any changes are needed.

nhoening

Quick review!

nhoening · 2026-05-18T16:45:44Z

 ADMIN_READER_ROLE = "admin-reader"
 ACCOUNT_ADMIN_ROLE = "account-admin"
 CONSULTANT_ROLE = "consultant"
+CONSULTANT_WITH_OWN_CLIENTS_ACCOUNT_ROLE = "CONSULTANT_WITH_OWN_CLIENTS"


Yes, as I said, I should do that research (I had similar conclusions) and maybe propose how to phrase this.
I have some ideas about a 2nd account role we could officially support, will open a discussion.

nhoening · 2026-05-18T16:48:43Z

            <div class="card">
-            <h3>All Accounts
-            </h3>
+          <div class="d-flex justify-content-between align-items-center">


No, I meant on a specific account page, add a button "Add client account".

The "add client button" is on the account page; you can find it when you open an account's properties. This page, where this comment is, is the "accounts" page that shows a table of all the accounts

Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

joshuaunity · 2026-05-19T08:11:34Z

It actually only happens when I make the window a bit more narrow.

Thanks that helps, ill look into it.

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

nhoening

I looked something up.

nhoening · 2026-05-20T14:06:12Z

+
+        try:
+            db.session.commit()
+        except IntegrityError:


What about this part in our central rollback handler (see transactional.py)?

def after_request_exception_rollback_session(exception): """...""" if exception is not None: db.session.rollback() return

It is registerd on the app for all requests:

app.teardown_request(after_request_exception_rollback_session)

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity added 2 commits May 5, 2026 13:35

Feat: implement account creation functionality with UI and API integr…

4bac1ff

…ation Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Feat: improve account creation validation for unique names and non-em…

b278a99

…pty values Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity self-assigned this May 15, 2026

joshuaunity added enhancement New feature or request API UI labels May 15, 2026

joshuaunity added 2 commits May 15, 2026 09:27

ref: improved account form UX with color picker additions

0f3ca03

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

chore: add changelog entry

e99fa0e

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Merge branch 'main' into feat/creata-accounts-UI

25504e2

Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

Copilot started work on behalf of joshuaunity May 15, 2026 12:41 View session

Copilot finished work on behalf of joshuaunity May 15, 2026 12:45

Copilot started work on behalf of joshuaunity May 15, 2026 12:48 View session

docs: improve changelog entry to mention both API and UI for account …

bb4b466

…creation Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/e49db96c-1da8-4a18-91ab-fc630290d726 Co-authored-by: joshuaunity <45713692+joshuaunity@users.noreply.github.com>

Copilot finished work on behalf of joshuaunity May 15, 2026 12:54

nhoening reviewed May 15, 2026

View reviewed changes

Copilot started work on behalf of joshuaunity May 18, 2026 04:18 View session

Copilot finished work on behalf of joshuaunity May 18, 2026 04:20

joshuaunity added 5 commits May 18, 2026 06:30

chore: update accoutn role name

198a092

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

ref: move advanced color picker to account edit form and add consulta…

44e3a96

…ncy input to account creation form Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: enhance account UI with 'Add client account' button for consult…

9bd8064

…ancy accounts and improve account selection logic Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: add account patch schema and enhance account roles management i…

2707f49

…n UI Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: enhance security documentation on account roles and their manag…

21cf7ae

…ement in UI Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

joshuaunity added 4 commits May 18, 2026 07:50

chore: modify changelog

64f0be0

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

ref: strip down permission guard

845514d

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Merge branch 'feat/creata-accounts-UI' of github.com:FlexMeasures/fle…

8c0f5bb

…xmeasures into feat/creata-accounts-UI Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: clarify consultancy account functionality and user roles in sec…

7cf7783

…urity documentation Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

nhoening requested changes May 18, 2026

View reviewed changes

joshuaunity and others added 2 commits May 19, 2026 09:09

Update flexmeasures/auth/policy.py

e30ab32

Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

Update flexmeasures/auth/policy.py

a5e0f85

Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: JDev <45713692+joshuaunity@users.noreply.github.com>

fix: fixed failing test using wrong user

879c811

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

nhoening reviewed May 20, 2026

View reviewed changes

joshuaunity added 3 commits May 21, 2026 14:10

chore: udpate docs

a3e83a0

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

fix: removed double scroolbar in users and accounts tables

39559c8

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

feat: add button to create client accounts in account details

c30938b

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Conversation

joshuaunity commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How to test

Related Items

Sign-off

Uh oh!

joshuaunity commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

nhoening commented May 15, 2026

Uh oh!

nhoening left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshuaunity commented May 18, 2026

Uh oh!

nhoening left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshuaunity commented May 19, 2026

Uh oh!

nhoening left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joshuaunity commented May 15, 2026 •

edited

Loading