Fix sensor forecast button to send train-start from available history#2187
Conversation
Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/ab24b03b-3e1f-47f0-a161-343395115540 Co-authored-by: BelhsanHmida <149331360+BelhsanHmida@users.noreply.github.com>
Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com> Signed-off-by: Nicolas Höning <iam@nicolashoening.de>
nhoening
left a comment
There was a problem hiding this comment.
I did my test with 3 days data and confirm that this improves the situation a lot. Forecasts still look a bit different on the edges, but the base behavior is forecasted better.
Please add a changelog entry (standard procedure), then this can go into the upcoming release!
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
|
Manual test passed. I compared the sensor page Trigger forecast flow against the equivalent CLI command on 15-minute resolution test data. The important thing I checked was that the button-triggered job no longer trains on the default 30-day window. The worker logs now show the training window starts from the available history instead: I then ran the matching CLI forecast with the same train-start, start, and duration. The resulting forecasts are identical, which confirms the button now sends the intended config.train-start and behaves like the CLI path. Also added a small follow-up fix so train-start is set for users who can trigger forecasts but do not have delete-data permission, plus test coverage for that rendered listener. |
Signed-off-by: Nicolas Höning <iam@nicolashoening.de>
config.train-startfrom first available data