Merged
Conversation
…dules/trigger and /sensors/<id>/schedules/<job_id> Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…in the endpoint documentation Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…g flexibility states together with triggering schedules Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
added
documentation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Collaborator
Pull Request Test Coverage Report for Build 2036804269
💛 - Coveralls |
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
requested changes
Mar 23, 2022
Contributor
nhoening
left a comment
nhoening
left a comment
There was a problem hiding this comment.
Approve of the scope of this PR. Only minor comments I believe.
As for the type field, I guess I'd not even introduce it in our API v3.
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…or roundtrip efficiency; also test whether the soc-min and soc-max fields get through validation Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
# Conflicts: # documentation/api/change_log.rst # documentation/api/v3_0.rst
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ing a schedule Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
This was referenced Mar 24, 2022
nhoening
approved these changes
Mar 24, 2022
Contributor
|
Addendum: I believe you should also change the |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ing to the new endpoints Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement RESTful endpoints for triggering scheduling jobs and fetching schedules. Deprecates the UDI Event ID in favor of letting the server create a Universally Unique Identifier (UUID), which is returned when a schedule is triggered. The UUID is used as a job id and can be used to fetch the exact schedule whose creation was triggered (for a limited time, similarly to what we had before with UDI Event IDs).
/api/v3_0/sensors/<id>/schedules/trigger [POST], which creates a scheduling job and returns the job's ID. Note that by default, rq makes a random UUID. The endpoint replaces postUdiEvent./api/v3_0/sensors/<id>/schedules/<uuid> [GET], which checks job status and returns the most recent schedule based on the job'skwargs["start"]. Not guaranteed to give the same result when queried at a later time, unless we also look for the schedule based on the job'skwargs["belief_time"]. In fact, the ID will not be known after a week, because we only store it temporarily in redis. Afterwards, the schedule can still be retrieved through/api/v3_0/sensors/<id>/data [GET], with appropriate filter values for "start", "prior" and "source". The endpoint replaces getDeviceMessage.Support optional "source" in /sensors/data [GET].Moved to Support optional "source" in /sensors/data [GET] #398.Support passing a custom uuid, which may be a UDI event ID.Moved to Support passing a custom uuid to /schedules/trigger [POST] #399.closes #393
closes #397