Added ability to ignore empty strings#107
Merged
Jeehut merged 4 commits intoFlineDev:stablefrom Sep 24, 2018
Merged
Conversation
Jeehut
reviewed
Sep 17, 2018
| for newTranslation in newTranslations { | ||
| // skip keys marked for ignore | ||
| guard !newTranslation.value.containsAny(of: ignores) else { continue } | ||
| if ignoreEmptyStrings && newTranslation.value.trimmingCharacters(in: .whitespaces).isEmpty { continue } |
Member
There was a problem hiding this comment.
You could use isBlank instead of trimmingCharacters(in: .whitespaces).isEmpty. It's implemented here. Technically it's not the same, since it also removes newlines, not sure if that's works for you as well. But if it does, I'd prefer that.
Member
|
Looks good overall, just added a small comment. Once that's answered it's good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #73, but I've added tests this time.