ct variable in getMoorings for symmetrics lines - broken or just not used?

[mattEhall]

In helpers.py getMoorings, there's a variable: ct = 0 # counter for number of line types

It seems to never get set, but is used in this for loop:

FAD-Toolset/famodel/helpers.py

Line 2146 in 9e610b8

for ii in range(0,ct-1): # go through every line config except the last (since it was doubled already)

So the loop will never run.
Is this something we need to fix, or is this capability obsolete?

[lsirkis]

Yes I believe I tried to remove ct as a variable, and forgot to complete that task. We rarely use symmetric setups in yamls so was never caught. There is a method in mooring.py (mirror()) that will complete a half-symmetric line, which is necessary when the mooring object is already created, like in cases where LineDesign is used and implemented into a project rather than using a yaml.

There are 2 options that I see to fix this:

1. Adjust the mooring class initialization to check for a "symmetric" flag somewhere in the dd and run mooring.mirror() within the initialization if flagged
2. Fix the loop in helpers.getMoorings() with the intended statement (for ii in range(len(config)-1) - this needs to be fixed for line 1006 as well.

I'm fine with either option (or open to other options). Happy to make whichever change.

[mattEhall]

Sounds good. Option 1 sounds maybe most code-efficient? I'm working on some modifications around these parts of the code so we could save the fix until later if it's not affecting anything.
Question: is the capability worth keeping? Do we want to keep support for the symmetric option in the YAML?

@Yuksel-Rudy @erickaloz ?

[Yuksel-Rudy]

I'm good with option 1. I never used the symmetric option from a YAML file and have always used the mirror() method within mooring.py.

[erickaloz]

option 1 is also good with me