Node and Edge class inheritance, addition of cables#3
Merged
Conversation
-- Add ID into each object -- Update getMoorPyArray() to have anchor points added before fairlead points
--Changed mass to m and volume to v in yaml file to match moorpy input --Updated some sample yaml files to match above change --Updated ontology read me to use correct values
--Changed from 'mass' and 'volume' in ontology yaml to 'm' and 'v' --Above change allows moorpy to recognize these properties without renaming, as moorpy uses 'm' and 'v' --Ontology sample files and ontology readme updated to reflect this change
- Joint and Cable classes at the low level (inheriting from Node and Edge) - StaticCable(Cable) and DynamicCable(Cable) - SubseaCable which is the whole thing, potentially including both static and dynamic cables.
--Initialize node inheritance for platform and anchor --Remove assignment of id for platform, anchor, mooring (inherited id)
--Working on cable ontology yaml setup and loading in project class --Created substation class (useful for specifying where array cables are going to) --Updated a few things in cable classes to run
--remove cable system class --remove cable class and have subsea cable inherit from edge class instead --continue adding cable stuff to load function
…tion description - Info should be passed in through dd['buoyancy_sections] dictionary.
-- Added project.addCablesConnections() to take in a dictionary containing cable routing and connection information, create cable objects, and attach cables to correct things --Minor changes to cable_ontology.yaml and fix to cable_properties.getCableProps to take in sources
--Continued work on loading in cables, forming connections --Debugging above work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR include the use of Node and Edge classes that array components inherit from. Cable objects are also more fleshed out. Currently the cable objects are not fully functional but base information is there.