Skip to content

Updated tipTip with new features#12

Open
danimesq wants to merge 4 commits intoFloflis:masterfrom
indyone:master
Open

Updated tipTip with new features#12
danimesq wants to merge 4 commits intoFloflis:masterfrom
indyone:master

Conversation

@danimesq
Copy link
Member

No description provided.

rtlDirCheckRe = new RegExp('^[^' + ltrChars + ']*[' + rtlChars + ']');

function isRtlText(text) {
return rtlDirCheckRe.test(text);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary semicolon.

tiptip_arrow
.css({ left: Math.round(arrow_left), top: Math.round(arrow_top) });
}
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

$('body').append(tiptip_holder);
} else {
var tiptip_holder = $('#tiptip_holder'),
tiptip_content = $('#tiptip_content'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'tiptip_arrow' is already defined.

tiptip_holder = $('<div>', { id: 'tiptip_holder' }).append(tiptip_arrow).append(tiptip_content);
$('body').append(tiptip_holder);
} else {
var tiptip_holder = $('#tiptip_holder'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'tiptip_content' is already defined.

tiptip_content = $('<div>', { id: 'tiptip_content' }),
tiptip_holder = $('<div>', { id: 'tiptip_holder' }).append(tiptip_arrow).append(tiptip_content);
$('body').append(tiptip_holder);
} else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'tiptip_holder' is already defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants