Cashed the SkinColors and Color#55
Merged
Floogen merged 2 commits intoFloogen:developmentfrom Feb 10, 2026
Merged
Conversation
Was getting a massive slow down when using a pack and found this was the cause. Was basically spamming it's self.
Owner
|
I was not able to replicate the performance issue from a quick test, but I can see the benefit of caching that data. Thank you for the pull request, I will include it with the upcoming release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was getting a massive slow down when using a pack and found this was the cause. Was basically spamming itself.
For reference was getting a fps drop of around 30 before and now it's a smooth 60.
There are more areas that need a little something but this was the main and most impactful one, from my testing.
Would you like a video showing a before and after? It won't show up that well through recording, but having an fps overlay enabled could help.