Skip to content

[codex] Fix EOT measurement timestep poses#1844

Merged
FlorianPfaff merged 4 commits intomainfrom
codex/fix-eot-measurement-timestep
Apr 26, 2026
Merged

[codex] Fix EOT measurement timestep poses#1844
FlorianPfaff merged 4 commits intomainfrom
codex/fix-eot-measurement-timestep

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Use the current timestep's ground truth when translating or rotating EOT target shapes in generate_measurements.
  • Add a regression test that generates fixed-count EOT measurements for two distant poses and verifies each timestep's samples stay within the corresponding translated shape.

Root Cause

The EOT generation loop iterated over t, but referenced groundtruth[0] when placing the target shape. Moving targets therefore produced every timestep's measurements around the first pose.

Validation

  • Not run locally; this workspace is read-only and the change was made through the GitHub connector.
  • Added tests/test_generate_measurements_eot.py to cover the failure mode.

@FlorianPfaff FlorianPfaff marked this pull request as ready for review April 25, 2026 07:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 15.83s
✅ JSON prettier 2 0 0 0 0.39s
✅ JSON v8r 2 0 0 2.97s
✅ MARKDOWN markdownlint 2 0 0 0 0.72s
✅ MARKDOWN markdown-table-formatter 2 0 0 0 0.24s
✅ PYTHON bandit 404 0 0 5.69s
✅ PYTHON black 404 2 0 0 8.2s
✅ PYTHON flake8 404 0 0 3.05s
✅ PYTHON isort 404 3 0 0 0.73s
✅ PYTHON mypy 404 0 0 5.1s
✅ PYTHON pylint 404 0 0 121.63s
✅ PYTHON ruff 404 3 0 0 0.07s
✅ REPOSITORY checkov yes no no 21.31s
✅ REPOSITORY gitleaks yes no no 10.74s
✅ REPOSITORY git_diff yes no no 0.04s
✅ REPOSITORY secretlint yes no no 7.2s
✅ REPOSITORY syft yes no no 3.51s
✅ REPOSITORY trivy-sbom yes no no 3.71s
✅ REPOSITORY trufflehog yes no no 19.46s
✅ YAML prettier 4 0 0 0 0.44s
✅ YAML v8r 4 0 0 5.02s
✅ YAML yamllint 4 0 0 0.46s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters PYTHON_PYLINT,PYTHON_BLACK,PYTHON_FLAKE8,PYTHON_ISORT,PYTHON_BANDIT,PYTHON_MYPY,PYTHON_RUFF,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

Test Results

    12 files  ± 0      12 suites  ±0   4h 27m 19s ⏱️ - 1m 8s
 1 149 tests + 1   1 149 ✅ + 1      0 💤 ±0  0 ❌ ±0 
14 080 runs  +12  10 720 ✅ +12  3 360 💤 ±0  0 ❌ ±0 

Results for commit fbbe30d. ± Comparison against base commit 57e4c67.

♻️ This comment has been updated with latest results.

@FlorianPfaff FlorianPfaff force-pushed the codex/fix-eot-measurement-timestep branch from 5726e7c to d388549 Compare April 25, 2026 21:49
@FlorianPfaff FlorianPfaff force-pushed the codex/fix-eot-measurement-timestep branch from 9429f6f to 62cb429 Compare April 25, 2026 21:54
@FlorianPfaff FlorianPfaff merged commit 256f1e8 into main Apr 26, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant