Skip to content

[codex] Derive GNN gate from measurement dimension#1848

Merged
FlorianPfaff merged 2 commits intocodex/fix-gnn-gating-thresholdfrom
codex/gnn-dimension-aware-gating
Apr 25, 2026
Merged

[codex] Derive GNN gate from measurement dimension#1848
FlorianPfaff merged 2 commits intocodex/fix-gnn-gating-thresholdfrom
codex/gnn-dimension-aware-gating

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Replace the fixed default GNN gate threshold with gating_probability=0.999 and gating_distance_threshold=None.
  • Derive the gate threshold in find_association() from the current measurement dimension.
  • Square computed distances when square_dist=True, and use the square-root chi-square threshold when square_dist=False.
  • Expand the gating threshold regression test to cover 2-D, 3-D, unsquared, and explicit-threshold behavior.

Root cause

The GNN default gate was a single numeric chi-square threshold tied to 2-D measurements. That made the default inappropriate for other measurement dimensions and left the square_dist setting disconnected from the actual distance scale.

Notes

This PR is stacked on #1845, which removes the accidental extra square from the original default threshold. Once #1845 lands, this can be retargeted to main if desired.

Validation

  • Verified the branch diff against codex/fix-gnn-gating-threshold contains only the dimension-aware GNN gating changes and test updates.
  • Not run locally; this Codex session has a read-only filesystem, so CI should run the test matrix on the PR.

@FlorianPfaff FlorianPfaff marked this pull request as ready for review April 25, 2026 08:32
@FlorianPfaff FlorianPfaff merged commit aaccca9 into codex/fix-gnn-gating-threshold Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant