[codex] Derive GNN gate from measurement dimension#1848
Merged
FlorianPfaff merged 2 commits intocodex/fix-gnn-gating-thresholdfrom Apr 25, 2026
Merged
[codex] Derive GNN gate from measurement dimension#1848FlorianPfaff merged 2 commits intocodex/fix-gnn-gating-thresholdfrom
FlorianPfaff merged 2 commits intocodex/fix-gnn-gating-thresholdfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gating_probability=0.999andgating_distance_threshold=None.find_association()from the current measurement dimension.square_dist=True, and use the square-root chi-square threshold whensquare_dist=False.Root cause
The GNN default gate was a single numeric chi-square threshold tied to 2-D measurements. That made the default inappropriate for other measurement dimensions and left the
square_distsetting disconnected from the actual distance scale.Notes
This PR is stacked on #1845, which removes the accidental extra square from the original default threshold. Once #1845 lands, this can be retargeted to
mainif desired.Validation
codex/fix-gnn-gating-thresholdcontains only the dimension-aware GNN gating changes and test updates.