Skip to content

[codex] Fix groundtruth object-array indexing#1856

Merged
FlorianPfaff merged 1 commit intomainfrom
codex/fix-groundtruth-object-indexing
Apr 25, 2026
Merged

[codex] Fix groundtruth object-array indexing#1856
FlorianPfaff merged 1 commit intomainfrom
codex/fix-groundtruth-object-indexing

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

@FlorianPfaff FlorianPfaff commented Apr 25, 2026

Summary

  • Read prior ground-truth states through the per-timestep object-array entry before indexing target rows.
  • Reuse a has_inputs flag so inputs=None is treated the same as missing inputs.
  • Use column-oriented controls (inputs[:, t - 1]) to match the existing (input_dim, n_timesteps - 1) assertion.
  • Add regression tests for noisy transitions, noiseless transitions, and input-driven transitions over multiple targets.

Root cause

generate_groundtruth stores each timestep as an element in a one-dimensional object array. Some custom transition paths indexed it as if it were a dense multidimensional array, which raises before transition callbacks can run. The input-driven branch also read rows from inputs even though the function validates inputs as timestep columns.

Validation

  • Inspected the branch diff through the GitHub connector.
  • Not run locally: this Codex session has a read-only filesystem, so changes were applied via GitHub API rather than a local checkout.

@FlorianPfaff FlorianPfaff marked this pull request as ready for review April 25, 2026 09:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 15.14s
✅ JSON prettier 2 0 0 0 0.45s
✅ JSON v8r 2 0 0 2.73s
✅ MARKDOWN markdownlint 2 0 0 0 0.64s
✅ MARKDOWN markdown-table-formatter 2 0 0 0 0.2s
✅ PYTHON bandit 394 0 0 5.48s
✅ PYTHON black 394 6 0 0 7.98s
✅ PYTHON flake8 394 0 0 2.98s
✅ PYTHON isort 394 10 0 0 0.73s
✅ PYTHON mypy 394 0 0 4.77s
✅ PYTHON pylint 394 0 0 117.72s
✅ PYTHON ruff 394 10 0 0 0.07s
✅ REPOSITORY checkov yes no no 21.66s
✅ REPOSITORY gitleaks yes no no 10.8s
✅ REPOSITORY git_diff yes no no 0.06s
✅ REPOSITORY secretlint yes no no 6.83s
✅ REPOSITORY syft yes no no 3.13s
✅ REPOSITORY trivy-sbom yes no no 2.41s
✅ REPOSITORY trufflehog yes no no 19.62s
✅ YAML prettier 4 0 0 0 0.44s
✅ YAML v8r 4 0 0 4.41s
✅ YAML yamllint 4 0 0 0.43s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters PYTHON_PYLINT,PYTHON_BLACK,PYTHON_FLAKE8,PYTHON_ISORT,PYTHON_BANDIT,PYTHON_MYPY,PYTHON_RUFF,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff force-pushed the codex/fix-groundtruth-object-indexing branch from a0be01f to 2945902 Compare April 25, 2026 09:42
@FlorianPfaff FlorianPfaff reopened this Apr 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

Test Results

    12 files  +    10      12 suites  +10   4h 28m 22s ⏱️ + 4h 8m 42s
 1 126 tests +     3   1 126 ✅ +    4      0 💤  -     1  0 ❌ ±0 
13 804 runs  +11 503  10 536 ✅ +8 838  3 268 💤 +2 665  0 ❌ ±0 

Results for commit d0d9a57. ± Comparison against base commit dc8dc2b.

♻️ This comment has been updated with latest results.

@FlorianPfaff FlorianPfaff force-pushed the codex/fix-groundtruth-object-indexing branch from 3f0340a to d53701d Compare April 25, 2026 12:44
@FlorianPfaff FlorianPfaff force-pushed the codex/fix-groundtruth-object-indexing branch from d53701d to d0d9a57 Compare April 25, 2026 12:45
@FlorianPfaff FlorianPfaff merged commit d1af27c into main Apr 25, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant