Fix hyperhemispherical uniform sampling#1918
Merged
FlorianPfaff merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
HyperhemisphericalUniformDistribution.sampleto mirror each sampled point based on its own last coordinate.Root cause
HypersphericalUniformDistribution.sample(n)returns samples shaped(n, dim + 1), but the hyperhemisphere sampler checkeds[-1, :], which reads the last sampled row instead of the last coordinate of every sample. Forn == 1, that could force all coordinates positive instead of only projecting to the upper hemisphere.Validation
$env:PYTHONPATH='src'; $env:PYRECEST_BACKEND='numpy'; python -m pytest -q tests/distributions/test_hyperhemispherical_uniform_distribution.py$env:PYTHONPATH='src'; $env:PYRECEST_BACKEND='numpy'; python -m pytest -q tests/distributions/test_hyperhemispherical_uniform_distribution.py tests/distributions/test_hyperspherical_uniform_distribution.py$env:PYTHONPATH='src'; $env:PYRECEST_BACKEND='pytorch'; python -m pytest -q tests/distributions/test_hyperhemispherical_uniform_distribution.py$env:PYTHONPATH='src'; $env:PYRECEST_BACKEND='jax'; python -m pytest -q tests/distributions/test_hyperhemispherical_uniform_distribution.pypython -m black --check src/pyrecest/distributions/hypersphere_subset/hyperhemispherical_uniform_distribution.py tests/distributions/test_hyperhemispherical_uniform_distribution.pypython -m ruff check src/pyrecest/distributions/hypersphere_subset/hyperhemispherical_uniform_distribution.py tests/distributions/test_hyperhemispherical_uniform_distribution.py