Skip to content

Fix S2 coordinate conversion validation#2195

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-sphere-subset-coordinate-validation-20260523
May 23, 2026
Merged

Fix S2 coordinate conversion validation#2195
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-sphere-subset-coordinate-validation-20260523

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • tighten S² coordinate conversion dimensionality assertions so all Cartesian/spherical inputs must actually be 1-D
  • fix the optional elevation-to-inclination conversion path to pass azimuth and computed colatitude in the correct order
  • add regression coverage for rejected matrix inputs and the elevation map_to_inclination=True path

Validation

  • python -m py_compile on the changed implementation and test files in a local scratch copy
  • connector compare confirms the PR is limited to src/pyrecest/distributions/hypersphere_subset/abstract_sphere_subset_distribution.py and tests/distributions/test_abstract_sphere_subset_distribution.py

Note: full pytest execution was not possible in the execution sandbox because direct GitHub checkout/install is unavailable; PR CI should run the repository suite.

@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 32.35s
✅ PYTHON black 2 0 0 0 1.67s
✅ PYTHON isort 2 0 0 0 0.4s
✅ REPOSITORY checkov yes no no 29.08s
✅ REPOSITORY gitleaks yes no no 15.92s
✅ REPOSITORY git_diff yes no no 0.05s
✅ REPOSITORY secretlint yes no no 15.24s
✅ REPOSITORY syft yes no no 1.61s
✅ REPOSITORY trivy-sbom yes no no 4.27s
✅ REPOSITORY trufflehog yes no no 22.55s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 23, 2026 12:59
@FlorianPfaff FlorianPfaff merged commit 2e3d0dd into main May 23, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant