Skip to content

Fix scalar parameters in additional circular constructors#2202

Merged
FlorianPfaff merged 10 commits into
mainfrom
codex/fix-scalar-constructors-v2-20260523
May 23, 2026
Merged

Fix scalar parameters in additional circular constructors#2202
FlorianPfaff merged 10 commits into
mainfrom
codex/fix-scalar-constructors-v2-20260523

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • coerce WrappedLaplaceDistribution scalar rate/skew parameters through the active backend before shape validation
  • coerce ToroidalVonMisesSineDistribution scalar coupling parameter through the active backend before shape validation
  • add regression coverage for Python-scalar constructor arguments matching backend-scalar behavior

Rationale

These constructors used .shape directly on parameters. That rejects documented/natural Python scalar inputs such as WrappedLaplaceDistribution(2.0, 1.3) and ToroidalVonMisesSineDistribution(mu, kappa, 0.5) before the backend has a chance to normalize them.

Validation

  • Inspected the branch diff via the GitHub connector; it changes only the two affected constructors and their focused tests.
  • Direct sandbox checkout/pytest execution was not possible because outbound git access is unavailable here; PR CI should run the backend/test matrix.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 23, 2026

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 55.31s
✅ JSON prettier 7 0 0 0 0.98s
✅ JSON v8r 7 0 0 4.91s
⚠️ MARKDOWN markdownlint 66 0 1 0 1.82s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.8s
✅ PYTHON black 755 2 0 0 39.75s
✅ PYTHON isort 755 2 0 0 5.54s
✅ REPOSITORY checkov yes no no 38.17s
✅ REPOSITORY gitleaks yes no no 13.15s
✅ REPOSITORY git_diff yes no no 0.08s
✅ REPOSITORY secretlint yes no no 23.25s
✅ REPOSITORY syft yes no no 2.22s
✅ REPOSITORY trivy-sbom yes no no 5.49s
✅ REPOSITORY trufflehog yes no no 24.06s
✅ YAML prettier 10 0 0 0 0.77s
✅ YAML v8r 10 0 0 11.54s
✅ YAML yamllint 10 0 0 0.58s

Detailed Issues

⚠️ MARKDOWN / markdownlint - 1 error
.github/pull_request_template.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Summary"]

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 23, 2026 15:57
@FlorianPfaff FlorianPfaff merged commit 44ddcae into main May 23, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant