Fix PyTorch random.choice population handling#2208
Merged
FlorianPfaff merged 2 commits intoMay 23, 2026
Conversation
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ COPYPASTE | jscpd | yes | no | no | 53.88s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 0.81s |
| ✅ JSON | v8r | 7 | 0 | 0 | 5.72s | |
| markdownlint | 66 | 0 | 1 | 0 | 1.78s | |
| ✅ MARKDOWN | markdown-table-formatter | 66 | 0 | 0 | 0 | 0.67s |
| ✅ PYTHON | black | 755 | 6 | 0 | 0 | 40.67s |
| ✅ PYTHON | isort | 755 | 6 | 0 | 0 | 3.3s |
| ✅ REPOSITORY | checkov | yes | no | no | 38.11s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 14.98s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.11s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 23.88s | |
| ✅ REPOSITORY | syft | yes | no | no | 3.89s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 6.85s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 22.92s | |
| ✅ YAML | prettier | 10 | 0 | 0 | 0 | 0.72s |
| ✅ YAML | v8r | 10 | 0 | 0 | 12.52s | |
| ✅ YAML | yamllint | 10 | 0 | 0 | 0.5s |
Detailed Issues
⚠️ MARKDOWN / markdownlint - 1 error
.github/pull_request_template.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Summary"]
Notices
📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

Show us your support by starring ⭐ the repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
random.choicepopulations so Python integer and list inputs match the NumPy/JAX backend contractRationale
The NumPy and JAX backend
random.choicehelpers accept NumPy-compatible populations such as5and[10, 20, 30]. The PyTorch backend previously asserted thatawas already a tensor, so otherwise portable code failed only under PyTorch.Validation
mainby two commits, behind by zero, and changes onlysrc/pyrecest/_backend/pytorch/random.pyandtests/test_backend_random.pychoicelogic with list, integer, and tensor populationsgithub.com; PR CI should run the backend test matrix