Skip to content

Fix scalar non-assignment costs in Murty assignments#2244

Merged
FlorianPfaff merged 3 commits into
mainfrom
assignment-cost-fix
May 25, 2026
Merged

Fix scalar non-assignment costs in Murty assignments#2244
FlorianPfaff merged 3 commits into
mainfrom
assignment-cost-fix

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Broadcast scalar and zero-dimensional array non-assignment costs to the required row/column length in murty_k_best_assignments.
  • Keep vector-valued non-assignment costs unchanged, with a clearer validation message.
  • Add regression coverage for Python scalar row costs and 0-D NumPy array column costs.

Rationale

row_non_assignment_costs=5.0 or col_non_assignment_costs=np.array(6.0) should behave as scalar broadcast costs. The old code reshaped scalar-like inputs to a length-one vector and rejected them whenever the corresponding problem dimension was not one.

Testing

  • Added tests/utils/test_assignment.py::MurtyAssignmentTest::test_scalar_non_assignment_costs_are_broadcast.
  • Full local pytest was not run because the execution container cannot resolve github.com; repository CI should run the focused assignment tests and full matrix.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 40.49s
✅ JSON prettier 7 0 0 0 0.83s
✅ JSON v8r 7 0 0 6.3s
✅ MARKDOWN markdownlint 66 0 0 0 1.72s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.81s
✅ PYTHON black 761 0 0 0 42.19s
✅ PYTHON isort 761 0 0 0 4.73s
✅ REPOSITORY checkov yes no no 48.1s
✅ REPOSITORY gitleaks yes no no 17.32s
✅ REPOSITORY git_diff yes no no 0.18s
✅ REPOSITORY secretlint yes no no 23.45s
✅ REPOSITORY syft yes no no 7.71s
✅ REPOSITORY trivy-sbom yes no no 6.98s
✅ REPOSITORY trufflehog yes no no 22.83s
✅ YAML prettier 11 0 0 0 0.76s
✅ YAML v8r 11 0 0 12.25s
✅ YAML yamllint 11 0 0 0.61s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 25, 2026 04:02
@FlorianPfaff FlorianPfaff merged commit 9f8546b into main May 25, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant