Skip to content

Validate negative time-offset max delta#2247

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/validate-time-offset-max-delta-main-20260525
May 25, 2026
Merged

Validate negative time-offset max delta#2247
FlorianPfaff merged 2 commits into
mainfrom
codex/validate-time-offset-max-delta-main-20260525

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • reject negative max_time_delta_s values in time-offset interpolation
  • add regression coverage for invalid negative tolerance input

Rationale

Negative maximum time-delta tolerances cannot have physical meaning. Before this change, time-offset calibration paths accepted them and silently marked all candidate rows invalid/empty instead of surfacing a configuration error. This now matches the bias-calibration helper’s nonnegative tolerance validation.

Testing

  • Added tests/calibration/test_time_offset_bias.py::TimeOffsetCalibrationTest::test_interpolation_rejects_negative_max_time_delta
  • Local full pytest could not be run because the execution container cannot resolve github.com; PR CI should run the focused calibration test and full matrix.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 25, 2026 04:21
@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 50.01s
✅ JSON prettier 7 0 0 0 1.3s
✅ JSON v8r 7 0 0 4.74s
✅ MARKDOWN markdownlint 66 0 0 0 1.93s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.78s
✅ PYTHON black 762 0 0 0 41.7s
✅ PYTHON isort 762 0 0 0 2.73s
✅ REPOSITORY checkov yes no no 48.57s
✅ REPOSITORY gitleaks yes no no 15.76s
✅ REPOSITORY git_diff yes no no 0.03s
✅ REPOSITORY secretlint yes no no 24.18s
✅ REPOSITORY syft yes no no 5.72s
✅ REPOSITORY trivy-sbom yes no no 6.23s
✅ REPOSITORY trufflehog yes no no 23.99s
✅ YAML prettier 11 0 0 0 0.68s
✅ YAML v8r 11 0 0 11.87s
✅ YAML yamllint 11 0 0 0.6s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 877a000 into main May 25, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant