Skip to content

Fix PyTorch mean integer backend inputs#2257

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-pytorch-mean-integer-inputs-20260525
May 25, 2026
Merged

Fix PyTorch mean integer backend inputs#2257
FlorianPfaff merged 2 commits into
mainfrom
fix-pytorch-mean-integer-inputs-20260525

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Promote non-floating/non-complex PyTorch backend mean inputs to the configured default floating dtype before reduction.
  • Preserve explicit dtype handling and NumPy-style axis/keepdims semantics.
  • Add a forced-PyTorch regression test for integer Python-list inputs.

Rationale

The public backend facade generally accepts NumPy-style array-like inputs. For the PyTorch backend, backend.mean([[1, 2, 3], [4, 5, 6]], axis=0, keepdims=True) previously converted the list to an integer tensor and forwarded it to torch.mean, which rejects integer tensors. NumPy returns a floating result for the same input.

Validation

  • Added tests/test_backend_mean_contract.py::test_pytorch_mean_accepts_integer_array_like_inputs.
  • Full local pytest could not be run from this execution environment; repository CI should run the focused regression and full matrix.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 25, 2026 14:24
@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 40.85s
✅ JSON prettier 7 0 0 0 0.82s
✅ JSON v8r 7 0 0 4.54s
✅ MARKDOWN markdownlint 66 0 0 0 1.81s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.78s
✅ PYTHON black 764 0 0 0 34.77s
✅ PYTHON isort 764 0 0 0 2.23s
✅ REPOSITORY checkov yes no no 43.32s
✅ REPOSITORY gitleaks yes no no 17.3s
✅ REPOSITORY git_diff yes no no 0.11s
✅ REPOSITORY secretlint yes no no 22.26s
✅ REPOSITORY syft yes no no 4.89s
✅ REPOSITORY trivy-sbom yes no no 5.72s
✅ REPOSITORY trufflehog yes no no 22.16s
✅ YAML prettier 11 0 0 0 0.63s
✅ YAML v8r 11 0 0 10.46s
✅ YAML yamllint 11 0 0 0.49s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit dd24efa into main May 25, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant