Skip to content

Fix non-vectorized Dirac transforms across backends#2272

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-dirac-nonvectorized-apply-main-20260526
May 26, 2026
Merged

Fix non-vectorized Dirac transforms across backends#2272
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-dirac-nonvectorized-apply-main-20260526

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Map non-vectorized Dirac transforms over complete Dirac particles instead of delegating to backend apply_along_axis.
  • Remove the fragile apply_along_axis(..., axis=1, ...) dependency from AbstractDiracDistribution.apply_function.
  • Add default-backend and optional PyTorch-backend regression coverage.

Bug fixed

AbstractDiracDistribution.apply_function(..., function_is_vectorized=False) intended to call the provided function once per Dirac particle. The previous implementation used backend.apply_along_axis(f, 1, dist.d), which is backend-sensitive and, under the PyTorch backend, iterates over coordinate columns rather than particle rows and stacks the result along the wrong axis. This can silently produce invalid transformed particles.

Validation

  • Compared branch against current main: 2 commits ahead, 0 behind.
  • Added focused regression coverage in tests/distributions/test_abstract_dirac_distribution.py.
  • Full local pytest was not run because the execution sandbox cannot resolve github.com; repository CI should run the focused tests and full matrix.

@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 53.53s
✅ JSON prettier 7 0 0 0 0.81s
✅ JSON v8r 7 0 0 5.48s
✅ MARKDOWN markdownlint 66 0 0 0 1.93s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.64s
✅ PYTHON black 766 0 0 0 39.67s
✅ PYTHON isort 766 0 0 0 2.39s
✅ REPOSITORY checkov yes no no 49.27s
✅ REPOSITORY gitleaks yes no no 17.86s
✅ REPOSITORY git_diff yes no no 0.05s
✅ REPOSITORY secretlint yes no no 22.65s
✅ REPOSITORY syft yes no no 3.72s
✅ REPOSITORY trivy-sbom yes no no 6.42s
✅ REPOSITORY trufflehog yes no no 23.84s
✅ YAML prettier 11 0 0 0 0.7s
✅ YAML v8r 11 0 0 10.14s
✅ YAML yamllint 11 0 0 0.53s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 26, 2026 10:04
@FlorianPfaff FlorianPfaff merged commit 19c07ac into main May 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant