Fix infinite log-weight normalization#2273
Merged
FlorianPfaff merged 2 commits intoMay 26, 2026
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
+inflog weight.+infweights and moment matching with a dominant infinite-weight hypothesis.Bug fixed
normalize_log_weightspreviously usednot np.isfinite(maximum)as a generic fallback to uniform weights. That is appropriate when all weights collapse to-inf/non-finite support, but it is mathematically wrong when one or more hypotheses have+inflog weights: those hypotheses should receive all probability mass. The old behavior could makemoment_match_gaussian_hypothesesaverage incompatible hypotheses even when one hypothesis has an infinite log-score advantage.Validation
main(5c989c29fa1d937e3b4b117610f69c7dba018a3d).main: 2 commits ahead, 0 behind; onlygaussian_hypothesis_mixture.pyand its focused tests changed.github.com; repository CI should run the focused regression tests and full matrix.