Skip to content

Validate bias application feature rows#2275

Merged
FlorianPfaff merged 5 commits into
mainfrom
codex/fix-bias-apply-feature-row-validation-main-latest-20260526
May 27, 2026
Merged

Validate bias application feature rows#2275
FlorianPfaff merged 5 commits into
mainfrom
codex/fix-bias-apply-feature-row-validation-main-latest-20260526

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Add an explicit SensorBiasCorrectionModel.apply shape check after bias prediction.
  • Reject feature arrays that do not produce exactly one predicted bias row per measurement.
  • Add regression coverage for mismatched and matching feature row counts.

Bug fixed

For nonconstant bias models, predict(features, n_rows=...) returns one bias row per feature row. apply() previously proceeded without checking that the predicted bias matrix matched the measurement matrix, so a single feature row could be silently broadcast to multiple measurements, or other row mismatches could fail later via NumPy boolean indexing/broadcasting. The patch fails fast with a clear ValueError.

Validation

  • Branch created from current main (acd35ff2fc999a78ae13d2116af1fba85aa0c39e).
  • Compared branch against main: 2 commits ahead, 0 behind; only src/pyrecest/calibration/bias.py and a focused calibration regression test changed.
  • Local pytest was not run because this execution environment cannot clone/install the repository from GitHub; repository CI should run the focused regression tests and full suite.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 44.73s
✅ JSON prettier 7 0 0 0 0.91s
✅ JSON v8r 7 0 0 4.01s
✅ MARKDOWN markdownlint 66 0 0 0 1.72s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.79s
✅ PYTHON black 769 1 0 0 33.77s
✅ PYTHON isort 769 2 0 0 2.21s
✅ REPOSITORY checkov yes no no 40.98s
✅ REPOSITORY gitleaks yes no no 15.48s
✅ REPOSITORY git_diff yes no no 0.06s
✅ REPOSITORY secretlint yes no no 25.13s
✅ REPOSITORY syft yes no no 3.65s
✅ REPOSITORY trivy-sbom yes no no 3.88s
✅ REPOSITORY trufflehog yes no no 21.14s
✅ YAML prettier 11 0 0 0 0.68s
✅ YAML v8r 11 0 0 10.92s
✅ YAML yamllint 11 0 0 0.48s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 26, 2026 15:13
@FlorianPfaff FlorianPfaff merged commit 748951b into main May 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant