Skip to content

Validate bias prediction row counts#2277

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/validate-bias-predict-row-count-main-latest-20260526
May 27, 2026
Merged

Validate bias prediction row counts#2277
FlorianPfaff merged 2 commits into
mainfrom
codex/validate-bias-predict-row-count-main-latest-20260526

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • validate SensorBiasCorrectionModel.predict(..., n_rows=...) as a nonnegative integer-like scalar
  • reject non-integral floats, booleans, arrays, NaN/inf, and negative row counts before prediction
  • add focused regression coverage for constant and feature-based bias models

Bug fixed

predict(..., n_rows=...) previously used int(n_rows) directly. That silently truncated values such as 1.5, accepted boolean row counts, and could let invalid row-count controls produce misleading predictions or low-level np.repeat errors. The patch fails fast with a clear ValueError while preserving valid integer-like scalar inputs.

Validation

  • Added focused tests in tests/calibration/test_bias_prediction_row_count.py.
  • Full local pytest was not run in this execution environment; repository CI should run the focused tests and full suite.

@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 54.21s
✅ JSON prettier 7 0 0 0 0.71s
✅ JSON v8r 7 0 0 4.22s
✅ MARKDOWN markdownlint 66 0 0 0 2.0s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.85s
✅ PYTHON black 768 1 0 0 40.32s
✅ PYTHON isort 768 1 0 0 3.04s
✅ REPOSITORY checkov yes no no 48.14s
✅ REPOSITORY gitleaks yes no no 17.28s
✅ REPOSITORY git_diff yes no no 0.06s
✅ REPOSITORY secretlint yes no no 22.52s
✅ REPOSITORY syft yes no no 3.29s
✅ REPOSITORY trivy-sbom yes no no 5.9s
✅ REPOSITORY trufflehog yes no no 25.01s
✅ YAML prettier 11 0 0 0 0.7s
✅ YAML v8r 11 0 0 11.7s
✅ YAML yamllint 11 0 0 0.64s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 27, 2026 08:01
@FlorianPfaff FlorianPfaff merged commit bcf8f62 into main May 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant