Skip to content

Handle nonfinite track observation ids#2282

Merged
FlorianPfaff merged 1 commit into
mainfrom
fix-main-codebase-bug
May 27, 2026
Merged

Handle nonfinite track observation ids#2282
FlorianPfaff merged 1 commit into
mainfrom
fix-main-codebase-bug

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Treat non-finite numeric observation IDs as missing values in track-matrix normalization.
  • Add regression coverage for np.inf and -np.inf in normalize_track_matrix.

Root Cause

normalize_track_matrix special-cased NaN but allowed numeric infinities to reach int(value), which raises OverflowError instead of normalizing invalid observation IDs consistently.

Validation

  • py -3.12 -m pytest -q tests\test_track_evaluation.py tests\test_track_metrics.py
  • py -3.12 -m ruff check src tests
  • git diff --check

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 27, 2026 12:03
@FlorianPfaff FlorianPfaff merged commit 197e94c into main May 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant