Skip to content

Reject NaN time delta cutoffs#2283

Merged
FlorianPfaff merged 1 commit into
mainfrom
fix-main-codebase-bug-2
May 27, 2026
Merged

Reject NaN time delta cutoffs#2283
FlorianPfaff merged 1 commit into
mainfrom
fix-main-codebase-bug-2

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Reject NaN values for calibration max_time_delta_s cutoffs before matching/interpolation.
  • Preserve np.inf as an accepted unbounded cutoff.
  • Add regression coverage for timestamp interpolation and bias training examples.

Root Cause

The calibration code only rejected negative maximum time deltas. NaN is not less than zero, so it could flow into comparisons like delta_s <= NaN, silently marking every candidate invalid and producing empty calibration matches instead of reporting bad input.

Validation

  • py -3.12 -m pytest -q tests\calibration\test_time_offset_bias.py tests\calibration\test_bias.py tests\calibration\test_bias_prediction_row_count.py
  • py -3.12 -m ruff check src tests
  • git diff --check

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 27, 2026 12:09
@github-actions
Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 45.69s
✅ JSON prettier 7 0 0 0 0.89s
✅ JSON v8r 7 0 0 5.17s
✅ MARKDOWN markdownlint 66 0 0 0 1.95s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.49s
✅ PYTHON black 771 2 0 0 33.59s
✅ PYTHON isort 771 2 0 0 2.36s
✅ REPOSITORY checkov yes no no 43.52s
✅ REPOSITORY gitleaks yes no no 16.64s
✅ REPOSITORY git_diff yes no no 0.11s
✅ REPOSITORY secretlint yes no no 22.85s
✅ REPOSITORY syft yes no no 4.11s
✅ REPOSITORY trivy-sbom yes no no 4.52s
✅ REPOSITORY trufflehog yes no no 21.43s
✅ YAML prettier 11 0 0 0 0.69s
✅ YAML v8r 11 0 0 10.4s
✅ YAML yamllint 11 0 0 0.49s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 8735d72 into main May 27, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant